logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: logging-log4j2 git commit: Reset sys prop at the end of the test. Use specific static imports instead of *.
Date Tue, 01 Sep 2015 23:50:01 GMT
C'mon, we agreed on this!

From our style guide:
No wildcard imports in the main tree

Wildcard imports, static or otherwise, are not used.

Static wildcard imports in the test tree

Wildcard static imports are encouraged for test imports like JUnit, EasyMock, and Hamcrest.


Sent from my iPhone

> On 2015/09/02, at 8:05, Gary Gregory <garydgregory@gmail.com> wrote:
> 
> Gross. If you have more than one * you have no idea where stuff comes from.
> 
> Gary
> 
>> On Tue, Sep 1, 2015 at 4:02 PM, Remko Popma <remko.popma@gmail.com> wrote:
>> The explicit static imports is not an improvement.
>> 
>> I much prefer
>> import static org.junit.Assert.*;
>> 
>> 
>> Sent from my iPhone
>> 
>> > On 2015/09/02, at 7:04, ggregory@apache.org wrote:
>> >
>> > import static org.junit.Assert.*;
>> 
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
>> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> 
> 
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> Java Persistence with Hibernate, Second Edition
> JUnit in Action, Second Edition
> Spring Batch in Action
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory

Mime
View raw message