logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: [10/11] logging-log4j2 git commit: LOG4J2-599 small test improvements
Date Sun, 09 Aug 2015 16:38:49 GMT
Thanks for fixing the @since tag.
About the Javadoc for the new interfaces, I was "heavily inspired" by
java.util.function.Supplier. I noticed this but if Oracle doesn't pay
attention to this internally then hey...

On Mon, Aug 10, 2015 at 1:20 AM, Gary Gregory <garydgregory@gmail.com>
wrote:

> Ironically, the Javadoc for org.apache.logging.log4j.util.Supplier are not
> Java 8 XHTML...
>
> Gary
>
> On Sun, Aug 9, 2015 at 9:19 AM, Gary Gregory <garydgregory@gmail.com>
> wrote:
>
>> "@since log4j-2.4" should be "@since 2.4"
>>
>> Gary
>>
>> ---------- Forwarded message ----------
>> From: <rpopma@apache.org>
>> Date: Sun, Aug 9, 2015 at 9:17 AM
>> Subject: [10/11] logging-log4j2 git commit: LOG4J2-599 small test
>> improvements
>> To: commits@logging.apache.org
>>
>>
>> LOG4J2-599 small test improvements
>>
>> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/bb6cb775
>> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/bb6cb775
>> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/bb6cb775
>>
>> Branch: refs/heads/master
>> Commit: bb6cb775099cfa2a4afbd08e28113a0c24bbd07b
>> Parents: b3ce3fc
>> Author: rpopma <rpopma@apache.org>
>> Authored: Mon Aug 10 00:58:25 2015 +0900
>> Committer: rpopma <rpopma@apache.org>
>> Committed: Mon Aug 10 00:58:25 2015 +0900
>>
>> ----------------------------------------------------------------------
>>  .../src/test/java/org/apache/logging/log4j/Logger2Test.java    | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>>
>> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/bb6cb775/log4j-api/src/test/java/org/apache/logging/log4j/Logger2Test.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/log4j-api/src/test/java/org/apache/logging/log4j/Logger2Test.java
>> b/log4j-api/src/test/java/org/apache/logging/log4j/Logger2Test.java
>> index 7509fc4..2b0247c 100644
>> --- a/log4j-api/src/test/java/org/apache/logging/log4j/Logger2Test.java
>> +++ b/log4j-api/src/test/java/org/apache/logging/log4j/Logger2Test.java
>> @@ -52,7 +52,7 @@ public class Logger2Test {
>>          }
>>      }
>>
>> -    class Logger2Impl extends AbstractLogger {
>> +    private static class Logger2Impl extends AbstractLogger {
>>          private static final long serialVersionUID = 1L;
>>
>>          boolean enabled = true;
>> @@ -110,7 +110,7 @@ public class Logger2Test {
>>      final Throwable throwable = new Error("I'm Bad");
>>      final Marker marker = MarkerManager.getMarker("test");
>>
>> -    class MyMessageSupplier implements MessageSupplier {
>> +    private class MyMessageSupplier implements MessageSupplier {
>>          public boolean invoked = false;
>>
>>          @Override
>> @@ -122,7 +122,7 @@ public class Logger2Test {
>>
>>      final MyMessageSupplier messageSupplier = new MyMessageSupplier();
>>
>> -    class MySupplier implements Supplier<String> {
>> +    private class MySupplier implements Supplier<String> {
>>          public boolean invoked = false;
>>
>>          @Override
>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>

Mime
View raw message