Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Date: Mon, 6 Apr 2015 16:13:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: log4j-dev@logging.apache.org
Message-ID: <JIRA.12788121.1428099455000.3837.1428336792384@Atlassian.JIRA>
In-Reply-To: <JIRA.12788121.1428099455000@Atlassian.JIRA>
References: <JIRA.12788121.1428099455000@Atlassian.JIRA>
 <JIRA.12788121.1428099455740@arcas>
Subject: [jira] [Commented] (LOG4J2-991) Async root logger config is
 defaulting includeLocation to true without use of Log4jContextSelector
 system property
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/LOG4J2-991?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1448=
1360#comment-14481360 ]=20

ASF GitHub Bot commented on LOG4J2-991:
---------------------------------------

GitHub user ryanrupp opened a pull request:

    https://github.com/apache/logging-log4j2/pull/9

    [LOG4J2-991] Fixed an issue that the async root logger configuration wa=
s...

    ... not defaulting include location to false.
   =20
    This could happen if async loggers were configured without the use of t=
he logger context system property as the logic from LoggerConfig.includeLoc=
ation was being used instead of AsyncLoggerConfig.includeLocation

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ryanrupp/logging-log4j2 LOG4J2-991

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/logging-log4j2/pull/9.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9
   =20
----
commit 357caceb1246eb048aa6d73432eaecdfc6bffa65
Author: Ryan Rupp <ryan.rupp@jda.com>
Date:   2015-04-06T16:09:31Z

    [LOG4J2-991] Fixed an issue that the async root logger configuration wa=
s not defaulting include location to false.
   =20
    This could happen if async loggers were configured without the use of t=
he logger context system property as the logic from LoggerConfig.includeLoc=
ation was being used instead of AsyncLoggerConfig.includeLocation

----


> Async root logger config is defaulting includeLocation to true without us=
e of Log4jContextSelector system property
> -------------------------------------------------------------------------=
-----------------------------------------
>
>                 Key: LOG4J2-991
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-991
>             Project: Log4j 2
>          Issue Type: Bug
>    Affects Versions: 2.1
>            Reporter: Ryan Rupp
>            Priority: Minor
>
> I'm using the approach detailed here - https://logging.apache.org/log4j/2=
.x/manual/async.html - under "Mixing Synchronous and Asynchronous Loggers" =
where we have the <asyncRoot> logger defined. I noticed this was slow so lo=
oked into it and noticed the location was being captured but I thought this=
 should default to false for async loggers. Looking into this, the line her=
e - https://github.com/apache/logging-log4j2/blob/master/log4j-core/src/mai=
n/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java#L239 - th=
e call to includeLocation() is actually calling LoggerConfig.includeLocatio=
n() which checks for the existence of the system property (which we don't h=
ave set), therefore include location defaults to true. I think instead it s=
hould be calling the includeLocation() static method inside of AsyncLoggerC=
onfig here - https://github.com/apache/logging-log4j2/blob/master/log4j-cor=
e/src/main/java/org/apache/logging/log4j/core/async/AsyncLoggerConfig.java#=
L204 - which would end up defaulting this to false correctly as the include=
Location value is actually null since I didn't explicitly configured it.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org