logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remko Popma (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (LOG4J2-985) AbstractFilter should not implement equals() and hashCode()
Date Sun, 05 Apr 2015 07:36:33 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Remko Popma closed LOG4J2-985.
------------------------------

> AbstractFilter should not implement equals() and hashCode()
> -----------------------------------------------------------
>
>                 Key: LOG4J2-985
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-985
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Filters
>    Affects Versions: 2.2
>            Reporter: Remko Popma
>            Assignee: Remko Popma
>            Priority: Minor
>             Fix For: 2.3
>
>
> For the same reasons as LOG4J2-891 was raised, {{equals()}} and {{hashCode()}} should
be removed from {{AbstractFilter}}.
> Similar to the approach for {{AbstractFilter}} I will keep the existing implementation
of equals() and rename it {{equalsImpl()}} (with the call to {{super.equals(obj)}} replaced
by {{super.equalsImpl(obj)}}).
> Similarly for hashCode() to {{hashCodeImpl()}}. The xxxImpl() methods will be protected,
similar to  the approach taken in {{AbstractFilter}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message