logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Broeng Jensen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-867) FlumeAppender: maxDelay not in seconds, but milliseconds
Date Mon, 13 Oct 2014 10:00:34 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14169150#comment-14169150
] 

Simon Broeng Jensen commented on LOG4J2-867:
--------------------------------------------

Sorry about the late reply on my part.

I have reviewed the related commits, and it looks good. I only noticed a minor documentation
issue on the FailoverAppender, the javadoc for retryIntervalSeconds is still using the intervalMillis
description.

Diff:
{code}
-     * @param retryIntervalString The retry intervalMillis.
+     * @param retryIntervalSeconds The retry intervalMillis.
{code}

From:

https://git-wip-us.apache.org/repos/asf?p=logging-log4j2.git;a=blobdiff;f=log4j-core/src/main/java/org/apache/logging/log4j/core/appender/FailoverAppender.java;h=9629a2935d11940e0a368a8a3aa5668f7c5d6dca;hp=c46096461c53cbe154876fefef9f2e4ab3841ada;hb=f6bd93ce9a25313164d1ef2634fdbfb8a9200a27;hpb=b46ee74349f796bb0297dbc0527de9a7c6d6e0d0

I'm assuming the documentation for maxDelay (https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender)
will be updated with the next release.

Should I close the issue?

> FlumeAppender: maxDelay not in seconds, but milliseconds
> --------------------------------------------------------
>
>                 Key: LOG4J2-867
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-867
>             Project: Log4j 2
>          Issue Type: Documentation
>          Components: Appenders
>    Affects Versions: 2.0.2
>            Reporter: Simon Broeng Jensen
>            Priority: Minor
>             Fix For: 2.1
>
>
> Hi,
> We are using FlumeAppender with Log4j2, version 2.0.2.
> The documentation, and javadoc, specifies maxDelay as using seconds, but it's actually
used as milliseconds (see FlumePersistentManager). 
> We would suggest updating the javadoc, and documentation at:
> https://logging.apache.org/log4j/2.x/manual/appenders.html#FlumeAppender



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message