Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9374511CBF for ; Sat, 20 Sep 2014 01:40:34 +0000 (UTC) Received: (qmail 14375 invoked by uid 500); 20 Sep 2014 01:40:34 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 14321 invoked by uid 500); 20 Sep 2014 01:40:34 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 14309 invoked by uid 99); 20 Sep 2014 01:40:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 20 Sep 2014 01:40:34 +0000 Date: Sat, 20 Sep 2014 01:40:34 +0000 (UTC) From: "Gary Gregory (JIRA)" To: log4j-dev@logging.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (LOG4J2-813) MarkerManager Log4jMarker.hasParents() returns opposite of correct result MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LOG4J2-813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Gregory resolved LOG4J2-813. --------------------------------- Resolution: Fixed Fix Version/s: 2.1 Fix pushed to master. Please verify and close. Gary > MarkerManager Log4jMarker.hasParents() returns opposite of correct result > ------------------------------------------------------------------------- > > Key: LOG4J2-813 > URL: https://issues.apache.org/jira/browse/LOG4J2-813 > Project: Log4j 2 > Issue Type: Bug > Components: API > Affects Versions: 2.0.2 > Reporter: David Erichsen > Priority: Minor > Labels: newbie > Fix For: 2.1 > > > Log4JMarker.hasParents() will return false when the marker has parents, and true when it has none. > The javadoc in the Marker interface indicates it should function the other way around: > {quote} > "Indicates whether this Marker has references to any other Markers. Return true if the Marker has parent Markers" > {quote} > The code for the implementation (that I could find) demonstrates that it would function in the opposite way as it is described in that javadoc: > {code} > @Override > public boolean hasParents() { > return this.parents == null; > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org For additional commands, e-mail: log4j-dev-help@logging.apache.org