Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 30E8911563 for ; Tue, 9 Sep 2014 14:32:18 +0000 (UTC) Received: (qmail 87547 invoked by uid 500); 9 Sep 2014 14:32:18 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 87501 invoked by uid 500); 9 Sep 2014 14:32:18 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 87491 invoked by uid 99); 9 Sep 2014 14:32:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 14:32:17 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com designates 209.85.216.171 as permitted sender) Received: from [209.85.216.171] (HELO mail-qc0-f171.google.com) (209.85.216.171) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Sep 2014 14:31:52 +0000 Received: by mail-qc0-f171.google.com with SMTP id x3so17108446qcv.2 for ; Tue, 09 Sep 2014 07:31:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=DmU4p6YzyDtNRcxI0ARfe9YeyJLyvmKwTZX7k5i57iQ=; b=buFVb5ldApfRz1rfukovQ8wah/tq0aqp0R+jOe6YWbK8PSbDIrAQjBS/eraWQX/Oe3 OQYijTkli5Icf2cypsUKO4BtB03zZ40/1ASRmhD4gILmFNIe3vUxbvRvd4sYb/XzCiNG Kw6slrWTAxGJwL1iVbGNkHHVTGnLpxkxiSGI+zo/7PJ40oqsRMuwUn7Mq9pJDZEv+6IA LHSjKvLb92uLexeh5HghTxzGWQC2zRal7XhRb8miSQED5i16dflJRJxxsv5rxwGlQSI7 eYMKXjOGEDyUIkXeJ9JN/IenEssVkTqisy9VMgjQjbDuY4xsKGW01Ey+6GD4h0gWiwpi a9ww== MIME-Version: 1.0 X-Received: by 10.224.36.130 with SMTP id t2mr2270309qad.45.1410273110194; Tue, 09 Sep 2014 07:31:50 -0700 (PDT) Received: by 10.140.128.84 with HTTP; Tue, 9 Sep 2014 07:31:50 -0700 (PDT) In-Reply-To: References: Date: Tue, 9 Sep 2014 10:31:50 -0400 Message-ID: Subject: Re: org.apache.logging.log4j.streams.util From: Gary Gregory To: Log4J Developers List Content-Type: multipart/alternative; boundary=089e0158b2ccc4ffe10502a2cb9e X-Virus-Checked: Checked by ClamAV on apache.org --089e0158b2ccc4ffe10502a2cb9e Content-Type: text/plain; charset=UTF-8 OK, so, The package is org.apache.logging.log4j.io.IoBuilder The class is IoBuilder The module is log4j-iostreams IMO the module name is out of sync with the rest, how about: log4j-javaio, log4j-java.io, log4j-io? Gary On Tue, Sep 9, 2014 at 10:10 AM, Matt Sicker wrote: > It's the IoBuilder class! :) > > > On 3 September 2014 17:44, Gary Gregory wrote: > >> Cool! I hope it's coming along nicely :-) >> >> Gary >> >> >> On Wed, Sep 3, 2014 at 3:16 PM, Matt Sicker wrote: >> >>> I'm working on the constructors thing. Make the API a bit nicer. >>> >>> >>> On 3 September 2014 12:19, Gary Gregory wrote: >>> >>>> Matt, feel free to whack on iostreams, I'm done in there for today. >>>> >>>> Gary >>>> >>>> >>>> On Wed, Sep 3, 2014 at 12:13 PM, Matt Sicker wrote: >>>> >>>>> That's still a possibility, but I'm still not sold on it. >>>>> >>>>> >>>>> On 3 September 2014 11:04, Gary Gregory >>>>> wrote: >>>>> >>>>>> Then what about matching the module name? log4j-io? >>>>>> >>>>>> Gary >>>>>> >>>>>> >>>>>> On Wed, Sep 3, 2014 at 9:17 AM, Matt Sicker wrote: >>>>>> >>>>>>> I'll take a look at the constructors and such. I think this is a >>>>>>> prime candidate for the builder pattern. >>>>>>> >>>>>>> Also, I renamed the o.a.l.l.streams package to o.a.l.l.io to match >>>>>>> the java.io package that this module emulates. I think it's a >>>>>>> pretty neat package name now (especially with the foo.io domain >>>>>>> name fad going on), but if there are objections, we can always name it >>>>>>> something else. >>>>>>> >>>>>>> >>>>>>> On 2 September 2014 23:59, Gary Gregory >>>>>>> wrote: >>>>>>> >>>>>>>> On Wed, Sep 3, 2014 at 12:32 AM, Matt Sicker >>>>>>>> wrote: >>>>>>>> >>>>>>>>> They almost seem like SPI classes in a sense of how the JDK >>>>>>>>> categorizes things sometimes. I wouldn't mind flattening them. They're all >>>>>>>>> of equal importance. >>>>>>>>> >>>>>>>> >>>>>>>> Done. >>>>>>>> >>>>>>>> I'm going to sleep now (1am here) but one thing you can look at >>>>>>>> Matt (or anyone) is how many of all the ctors we really need. There are >>>>>>>> quite a few. >>>>>>>> >>>>>>>> Gary >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> On 2 September 2014 09:54, Gary Gregory >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Any thoughts on folding the two classes in >>>>>>>>>> >>>>>>>>>> org.apache.logging.log4j.streams.util >>>>>>>>>> >>>>>>>>>> back into: >>>>>>>>>> >>>>>>>>>> org.apache.logging.log4j.streams >>>>>>>>>> >>>>>>>>>> They are both hard wired to an ExtendedLogger. >>>>>>>>>> >>>>>>>>>> I could see those being a Core or API util package if they are to >>>>>>>>>> be in one. >>>>>>>>>> >>>>>>>>>> Thoughts? >>>>>>>>>> >>>>>>>>>> Gary >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>> >>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>> >>>>>>>>>> Spring Batch in Action >>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Matt Sicker >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>> >>>>>>>> JUnit in Action, Second Edition >>>>>>>> Spring Batch in Action >>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>> Home: http://garygregory.com/ >>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Matt Sicker >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>>>> Java Persistence with Hibernate, Second Edition >>>>>> >>>>>> JUnit in Action, Second Edition >>>>>> Spring Batch in Action >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Matt Sicker >>>>> >>>> >>>> >>>> >>>> -- >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>> Java Persistence with Hibernate, Second Edition >>>> >>>> JUnit in Action, Second Edition >>>> Spring Batch in Action >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> Matt Sicker >>> >> >> >> >> -- >> E-Mail: garydgregory@gmail.com | ggregory@apache.org >> Java Persistence with Hibernate, Second Edition >> >> JUnit in Action, Second Edition >> Spring Batch in Action >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > Matt Sicker > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --089e0158b2ccc4ffe10502a2cb9e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
OK, so,

The package = is org.apache.logging.log4j.io.IoBuilder
The class is IoBuilder
The module is log4j-iostreams

IMO the module name is ou= t of sync with the rest, how about: log4j-javaio, log4j-java.io, log4j-io?

Gary

On Tue, Sep 9, 2014 at 10:1= 0 AM, Matt Sicker <boards@gmail.com> wrote:
It's the IoBuilder class! :)


On 3 September 2014 17:44, Gary Gregory <garydgregory@gmail.com&= gt; wrote:
Cool! I hope it's coming along nicely :-) =

Gary


On Wed, Sep 3, 2014 at 3:16 PM, Matt = Sicker <boards@gmail.com> wrote:
I'm working on the cons= tructors thing. Make the API a bit nicer.


On 3 September 2014 12:19, Gary Gre= gory <garydgregory@gmail.com> wrote:
Matt, feel free to whack on= iostreams, I'm done in there for today.<= br>
Gary

On Wed, Sep 3, 2014 at 12:13 PM, Matt Sicker <= span dir=3D"ltr"><= boards@gmail.com> wrote:
That's still a possibil= ity, but I'm still not sold on it.
=


On 3 September 2014 11:04, Gary Gre= gory <garydgregory@gmail.com> wrote:
Then what about matchi= ng the module name? log4j-io?

Gary


= On Wed, Sep 3, 2014 at 9:17 AM, Matt Sicker <boards@gmail.com> wrote:
I'll take a look at the= constructors and such. I think this is a prime candidate for the builder p= attern.

Also, I renamed the o.a.l.l.streams package to o.a.l.l.io to match the java.io package that this module emula= tes. I think it's a pretty neat package name now (especially with the <= a href=3D"http://foo.io" target=3D"_blank">foo.io domain name fad going= on), but if there are objections, we can always name it something else.


On 2 September 2014 23:59, Gary Gregory <garydgregory@gmail.com> wrote:
=
On Wed, Sep 3, 2014 at 12:32 AM, Matt Sicke= r <boards@gmail.com> wrote:
They almost seem like SPI c= lasses in a sense of how the JDK categorizes things sometimes. I wouldn'= ;t mind flattening them. They're all of equal importance.

Done.

I'= m going to sleep now (1am here) but one thing you can look at Matt (or anyo= ne) is how many of all the ctors we really need. There are quite a few.

Gary



On 2 September 2014 09:54, Gary Gregory <garydgregory@gmail.com&g= t; wrote:
Any thoughts on folding the two classes in =

org.apache.logging.log4j.streams.util

back into:
org.apache.logging.log4j.streams

They are both hard wired to= an ExtendedLogger.

I could see those being a Core or API util package if they a= re to be in one.

Thoughts?<= br>
Gary



--
Matt Sicker <boards@gmail.com>



<= font color=3D"#888888">--
Matt Sicker <boards@gmail.com>



--



= --
Matt Sicker <boards@gmail.com>



--



= --
Matt Sicker <boards@gmail.com>



--



--
Matt Sicker <= boards@gmail.com&= gt;


--
--089e0158b2ccc4ffe10502a2cb9e--