logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: org.apache.logging.log4j.streams.util
Date Tue, 09 Sep 2014 14:31:50 GMT
OK, so,

The package is org.apache.logging.log4j.io.IoBuilder
The class is IoBuilder
The module is log4j-iostreams

IMO the module name is out of sync with the rest, how about: log4j-javaio,
log4j-java.io, log4j-io?

Gary

On Tue, Sep 9, 2014 at 10:10 AM, Matt Sicker <boards@gmail.com> wrote:

> It's the IoBuilder class! :)
>
>
> On 3 September 2014 17:44, Gary Gregory <garydgregory@gmail.com> wrote:
>
>> Cool! I hope it's coming along nicely :-)
>>
>> Gary
>>
>>
>> On Wed, Sep 3, 2014 at 3:16 PM, Matt Sicker <boards@gmail.com> wrote:
>>
>>> I'm working on the constructors thing. Make the API a bit nicer.
>>>
>>>
>>> On 3 September 2014 12:19, Gary Gregory <garydgregory@gmail.com> wrote:
>>>
>>>> Matt, feel free to whack on iostreams, I'm done in there for today.
>>>>
>>>> Gary
>>>>
>>>>
>>>> On Wed, Sep 3, 2014 at 12:13 PM, Matt Sicker <boards@gmail.com> wrote:
>>>>
>>>>> That's still a possibility, but I'm still not sold on it.
>>>>>
>>>>>
>>>>> On 3 September 2014 11:04, Gary Gregory <garydgregory@gmail.com>
>>>>> wrote:
>>>>>
>>>>>> Then what about matching the module name? log4j-io?
>>>>>>
>>>>>> Gary
>>>>>>
>>>>>>
>>>>>> On Wed, Sep 3, 2014 at 9:17 AM, Matt Sicker <boards@gmail.com>
wrote:
>>>>>>
>>>>>>> I'll take a look at the constructors and such. I think this is
a
>>>>>>> prime candidate for the builder pattern.
>>>>>>>
>>>>>>> Also, I renamed the o.a.l.l.streams package to o.a.l.l.io to
match
>>>>>>> the java.io package that this module emulates. I think it's a
>>>>>>> pretty neat package name now (especially with the foo.io domain
>>>>>>> name fad going on), but if there are objections, we can always
name it
>>>>>>> something else.
>>>>>>>
>>>>>>>
>>>>>>> On 2 September 2014 23:59, Gary Gregory <garydgregory@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>>> On Wed, Sep 3, 2014 at 12:32 AM, Matt Sicker <boards@gmail.com>
>>>>>>>> wrote:
>>>>>>>>
>>>>>>>>> They almost seem like SPI classes in a sense of how the
JDK
>>>>>>>>> categorizes things sometimes. I wouldn't mind flattening
them. They're all
>>>>>>>>> of equal importance.
>>>>>>>>>
>>>>>>>>
>>>>>>>> Done.
>>>>>>>>
>>>>>>>> I'm going to sleep now (1am here) but one thing you can look
at
>>>>>>>> Matt (or anyone) is how many of all the ctors we really need.
There are
>>>>>>>> quite a few.
>>>>>>>>
>>>>>>>> Gary
>>>>>>>>
>>>>>>>>
>>>>>>>>>
>>>>>>>>> On 2 September 2014 09:54, Gary Gregory <garydgregory@gmail.com>
>>>>>>>>> wrote:
>>>>>>>>>
>>>>>>>>>> Any thoughts on folding the two classes in
>>>>>>>>>>
>>>>>>>>>> org.apache.logging.log4j.streams.util
>>>>>>>>>>
>>>>>>>>>> back into:
>>>>>>>>>>
>>>>>>>>>> org.apache.logging.log4j.streams
>>>>>>>>>>
>>>>>>>>>> They are both hard wired to an ExtendedLogger.
>>>>>>>>>>
>>>>>>>>>> I could see those being a Core or API util package
if they are to
>>>>>>>>>> be in one.
>>>>>>>>>>
>>>>>>>>>> Thoughts?
>>>>>>>>>>
>>>>>>>>>> Gary
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>>>> <http://www.manning.com/bauer3/>
>>>>>>>>>> JUnit in Action, Second Edition
>>>>>>>>>> <http://www.manning.com/tahchiev/>
>>>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>>>> Home: http://garygregory.com/
>>>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Matt Sicker <boards@gmail.com>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>>>> <http://www.manning.com/bauer3/>
>>>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>>>> Blog: http://garygregory.wordpress.com
>>>>>>>> Home: http://garygregory.com/
>>>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Matt Sicker <boards@gmail.com>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>>> Java Persistence with Hibernate, Second Edition
>>>>>> <http://www.manning.com/bauer3/>
>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>>> Blog: http://garygregory.wordpress.com
>>>>>> Home: http://garygregory.com/
>>>>>> Tweet! http://twitter.com/GaryGregory
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <boards@gmail.com>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>> Java Persistence with Hibernate, Second Edition
>>>> <http://www.manning.com/bauer3/>
>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>> Blog: http://garygregory.wordpress.com
>>>> Home: http://garygregory.com/
>>>> Tweet! http://twitter.com/GaryGregory
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <boards@gmail.com>
>>>
>>
>>
>>
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> Java Persistence with Hibernate, Second Edition
>> <http://www.manning.com/bauer3/>
>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>> Spring Batch in Action <http://www.manning.com/templier/>
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
>>
>
>
>
> --
> Matt Sicker <boards@gmail.com>
>



-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message