logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-744) Aviod unnecessary Clock calls when TimestampMessage is logged
Date Mon, 28 Jul 2014 18:06:41 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076497#comment-14076497

Gary Gregory commented on LOG4J2-744:

I think {{isTimestampSet()}} is more clear. To me, {{hasTimestamp()}} answers the question
"Do you carry a timestamp of any kind?" as opposed to "Is your timestamp value set?". If an
object has no timestamp, a return value of {{false}} makes sense.

> Aviod unnecessary Clock calls when TimestampMessage is logged
> -------------------------------------------------------------
>                 Key: LOG4J2-744
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-744
>             Project: Log4j 2
>          Issue Type: Improvement
>            Reporter: Scott Harrington
>            Priority: Minor
>         Attachments: LOG4J2-744-test.patch, LOG4J2-744.patch
> The TimestampMessage interface was introduced in LOG4J2-53 and revised for AsyncLogger
in LOG4J2-455.
> I've observed that Clock.currentTimeMillis is still called which should not be necessary.
> I have two patches, one which adds JUnit tests that demonstrate the unnecessary Clock
calls, and one which fixes the issue for both AsyncLogger and "traditional" configurations.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message