logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject org.apache.logging.log4j.core.config.plugins.PluginAttribute.required()
Date Mon, 07 Jul 2014 15:35:30 GMT
Why don't we have a required flag?

Using it and throwing an Exception when this condition is violated would
avoid guard code like:

    @PluginFactory
    public static RegexFilter createFilter(
            @PluginAttribute("regex") final Pattern regex,
            @PluginAttribute("useRawMsg") final Boolean useRawMsg,
            @PluginAttribute("onMatch") final Result match,
            @PluginAttribute("onMismatch") final Result mismatch) {

        if (regex == null) {
            LOGGER.error("A regular expression must be provided for
RegexFilter");
            return null;
        }
        return new RegexFilter(useRawMsg, regex, match, mismatch);
    }

?

-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message