Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Date: Sun, 22 Jun 2014 00:16:24 +0000 (UTC)
From: "Ralph Goers (JIRA)" <jira@apache.org>
To: log4j-dev@logging.apache.org
Message-ID: <JIRA.12722580.1403208991543.24252.1403396184839@arcas>
In-Reply-To: <JIRA.12722580.1403208991543@arcas>
References: <JIRA.12722580.1403208991543@arcas>
Subject: [jira] [Comment Edited] (LOG4J2-673) plugin preloading fails in
 shaded jar files
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/LOG4J2-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039996#comment-14039996 ] 

Ralph Goers edited comment on LOG4J2-673 at 6/22/14 12:14 AM:
--------------------------------------------------------------

Matt, in case you didn't notice in my comments I do not want this version of the patch committed.  Oops. I have not checked the latest patch. Please wait until I have a chance to review it.


was (Author: ralph.goers@dslextreme.com):
Matt, in case you didn't notice in my comments I do not want this version of the patch committed.

> plugin preloading fails in shaded jar files
> -------------------------------------------
>
>                 Key: LOG4J2-673
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-673
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 2.0-rc2
>            Reporter: Mck SembWever
>            Priority: Critical
>              Labels: annotations, compiler, plugins
>             Fix For: 2.0-rc2
>
>         Attachments: 0002-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch, 0003-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch
>
>
> Support for plugin preloading through the standard javax.annotation.processing tool was adding in LOG4J2-595
> But the plugin processor always creates and stores the processed "Plugin" annotated classes into the same file. This works fine when the classpath consists of individual jar files, but fails when shaded jar files are used.
> A tested fix exists at https://github.com/finn-no/logging-log4j2/tree/bugfix/LOG4J2-673
> There's also a github pull request and a manual diff attached. (I can clean up anything not used afterwards)
> The fix saves the dat file in a location under META-INF that matches the shared package all the processed plugins are found under.
> The package attribute in the config file is then used so that multiple dat files can be loaded at runtime.
> This means that the package attribute is no longer deprecated.
> This has been tested against https://github.com/finn-no/log4j2-logstash-jsonevent-layout


--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org