logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: Config clean up for AppenderRef
Date Tue, 03 Jun 2014 01:28:59 GMT
Hm, why not adopt the same convention as Ant? It would be nicer IMO:

<File id="MyAppender />
<AppenderRef refid="MyAppender />

Both attributes have "id" in their name so the connection is more obvious.

Gary


On Mon, Jun 2, 2014 at 5:24 AM, Ralph Goers <rgoers@apache.org> wrote:

> I think I agree with Remko. I think ref= is clearer.
>
> Sent from my iPad
>
> On Jun 2, 2014, at 1:48 AM, Remko Popma <remko.popma@gmail.com> wrote:
>
> Hm, not sure. Two things:
>
> That would require our existing users to modify their configurations.
>
> Also, currently the "name" attribute  provides an identifier for its
> element so that other elements can reference it. Isn't it clearer to have a
> different attribute when referring to another element? I think calling this
> attribute "ref" is very clear actually and I don't think having the same
> name for attributes that refer and attributes attributes that are being
> referred to is better.
>
> Sent from my iPhone
>
> On 2014/06/02, at 15:46, Gary Gregory <garydgregory@gmail.com> wrote:
>
> In the following:
>
>     <File name="File" fileName="${filename}">
>       <PatternLayout>
>         <Pattern>${pattern}</Pattern>
>       </PatternLayout>
>     </File>
> ...
>   <Loggers>
>     <Root level="Debug">
>       <AppenderRef ref="File" />
>     </Root>
>   </Loggers>
>
> I propose to change:
>
> <AppenderRef ref="File" />
>
> to:
>
> <AppenderRef name="File" />
>
> It seems easier to read and connect these dots:
>
> <File name="File"
> ...
> <AppenderRef name="File" />
>
> Thoughts?
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition
> <http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition
<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message