logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <ralph.go...@dslextreme.com>
Subject Re: [jira] [Commented] (LOG4J2-673) plugin preloading fails in shaded jar files
Date Mon, 30 Jun 2014 22:25:10 GMT
I would hope a month at most.  

Ralph

On Jun 30, 2014, at 3:11 PM, Mck SembWever (JIRA) <jira@apache.org> wrote:

> 
>    [ https://issues.apache.org/jira/browse/LOG4J2-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14048235#comment-14048235
] 
> 
> Mck SembWever commented on LOG4J2-673:
> --------------------------------------
> 
> {quote} I hope to be able to do it in the next day or two.{quote}
> No stress, i'm keen to not have this forgotten before the 2.0 release, not sure when
that is estimated?
> 
>> plugin preloading fails in shaded jar files
>> -------------------------------------------
>> 
>>                Key: LOG4J2-673
>>                URL: https://issues.apache.org/jira/browse/LOG4J2-673
>>            Project: Log4j 2
>>         Issue Type: Bug
>>         Components: Core
>>   Affects Versions: 2.0-rc2
>>           Reporter: Mck SembWever
>>           Priority: Critical
>>             Labels: annotations, compiler, plugins
>>            Fix For: 2.0
>> 
>>        Attachments: 0002-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch,
0005-LOG4J2-673-plugin-preloading-fails-in-shaded-jar-fil.patch
>> 
>> 
>> Support for plugin preloading through the standard javax.annotation.processing tool
was adding in LOG4J2-595
>> But the plugin processor always creates and stores the processed "Plugin" annotated
classes into the same file. This works fine when the classpath consists of individual jar
files, but fails when shaded jar files are used.
>> A tested fix exists at https://github.com/finn-no/logging-log4j2/tree/bugfix/LOG4J2-673
>> There's also a github pull request and a manual diff attached. (I can clean up anything
not used afterwards)
>> The fix saves the dat file in a location under META-INF that matches the shared package
all the processed plugins are found under.
>> The package attribute in the config file is then used so that multiple dat files
can be loaded at runtime.
>> This means that the package attribute is no longer deprecated.
>> This has been tested against https://github.com/finn-no/log4j2-logstash-jsonevent-layout
> 
> 
> 
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message