logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stefan Wehner (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LOG4J2-657) AbstractDatabaseManager doesn't close connection on writeInternal error
Date Thu, 29 May 2014 14:37:01 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Stefan Wehner updated LOG4J2-657:
---------------------------------

    Description: 
When using the JDBCAppender: if the AbstractDatabaseManager.writeInternal() method fails (e.g.
value to large for column size, or any other database error) the database connection is not
closed.

I've attached a proposed patch to fix this - please take a look and see if it makes sense
to handle write failures this way.


  was:
When the writeInternal method fails (e.g. value to large for column size, or any other database
error) the connection is not closed.

I've attached a proposed patch to fix this - please take a look and see if it makes sense
to handle write failures this way.



> AbstractDatabaseManager doesn't close connection on writeInternal error
> -----------------------------------------------------------------------
>
>                 Key: LOG4J2-657
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-657
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.0-rc2
>            Reporter: Stefan Wehner
>         Attachments: finally.patch
>
>
> When using the JDBCAppender: if the AbstractDatabaseManager.writeInternal() method fails
(e.g. value to large for column size, or any other database error) the database connection
is not closed.
> I've attached a proposed patch to fix this - please take a look and see if it makes sense
to handle write failures this way.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message