logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: ConfigurablePluginBuilder vs. Builder
Date Mon, 26 May 2014 19:17:10 GMT
Sounds like a good idea to me! I'll go ahead and make the change.


On 26 May 2014 08:20, Gary Gregory <garydgregory@gmail.com> wrote:

> We have a new interface:
>
> public interface ConfigurablePluginBuilder<T> {
>
>     /**
>      * Builds the plugin object after all configuration has been set. This
> will use default values for any
>      * unspecified attributes for the plugin.
>      *
>      * @return the configured plugin instance.
>      */
>     T build();
> }
>
> Which seems like it could be better named as Builder since all it does is
> build().
>
> This would make friendlier to reuse.
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
Matt Sicker <boards@gmail.com>

Mime
View raw message