logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Sicker <boa...@gmail.com>
Subject Re: Unit test failures
Date Sun, 27 Apr 2014 20:18:39 GMT
It's specified in the pluginManagement section now. I might have changed
that when I was cleaning up the OSGi stuff.


On 27 April 2014 15:15, Ralph Goers <ralph.goers@dslextreme.com> wrote:

> I thought they all did - or it used to be in the parent pom.
>
> Ralph
>
> On Apr 27, 2014, at 12:57 PM, Matt Sicker <boards@gmail.com> wrote:
>
> Done. Looks like any jar-type project needs to include the
> maven-bundle-plugin in their build section.
>
>       <plugin>
>         <groupId>org.apache.felix</groupId>
>         <artifactId>maven-bundle-plugin</artifactId>
>       </plugin>
>
>
>
> On 27 April 2014 14:55, Matt Sicker <boards@gmail.com> wrote:
>
>> On it.
>>
>>
>> On 27 April 2014 14:48, Ralph Goers <ralph.goers@dslextreme.com> wrote:
>>
>>> OK, but now the Flume samples are failing with the same error.  Do you
>>> think you could run the full build and get it to work?
>>>
>>> Ralph
>>>
>>> On Apr 27, 2014, at 12:40 PM, Matt Sicker <boards@gmail.com> wrote:
>>>
>>> Fixed it.
>>>
>>>
>>> On 27 April 2014 14:38, Matt Sicker <boards@gmail.com> wrote:
>>>
>>>> Now that's a weird one. I'll figure that out right after I finish
>>>> running the log4j-core unit tests before a new commit.
>>>>
>>>>
>>>> On 27 April 2014 14:30, Ralph Goers <ralph.goers@dslextreme.com> wrote:
>>>>
>>>>> <sigh>
>>>>>
>>>>> Now the build is failing in the taglib project due to a missing
>>>>> MANIFEST.MF, which I find unusual because the jar plugin normally creates
>>>>> that.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 26, 2014, at 10:51 PM, Ralph Goers <ralph.goers@dslextreme.com>
>>>>> wrote:
>>>>>
>>>>> FileOutputTest was failing because the status level was changed to OFF
>>>>> and the test is expecting status logs to be written to a file.  I’m
not
>>>>> sure how why this commit was ever done since a “mvn clean install”
would
>>>>> have failed.  Let me reiterate one more time.  If the unit tests fail
don’t
>>>>> commit - you did something wrong as the unit tests should ALWAYS pass.
>>>>>
>>>>> Ralph
>>>>>
>>>>>
>>>>>
>>>>> On Apr 26, 2014, at 10:30 PM, Ralph Goers <ralph.goers@dslextreme.com>
>>>>> wrote:
>>>>>
>>>>> The error in CustomConfigurationTest is now fixed. On to
>>>>> FileOutputTest.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 26, 2014, at 10:23 PM, Ralph Goers <ralph.goers@dslextreme.com>
>>>>> wrote:
>>>>>
>>>>> I finally got a chance to look at CustomConfigurationTest.  As I
>>>>> suspected the unit test is incorrect.
>>>>>
>>>>> A check was added to see if the StatusLogger’s level was changed to
>>>>> info.  However, setting status=“info” doesn’t change the level
of the
>>>>> Logger attached to the status logger. It changes the Level associated
with
>>>>> the ConsoleListener added by the configuration.  So this error has nothing
>>>>> to do with LOG4J2-607.
>>>>>
>>>>> I should have a fix committed in a little bit.
>>>>>
>>>>> Ralph
>>>>>
>>>>> On Apr 21, 2014, at 12:03 AM, Matt Sicker <boards@gmail.com> wrote:
>>>>>
>>>>> The first unit test failure there is due to LOG4J2-607. The second:
>>>>> not sure.
>>>>>
>>>>>
>>>>> On 21 April 2014 00:05, Ralph Goers <ralph.goers@dslextreme.com>wrote:
>>>>>
>>>>>> I just did a fresh checkout and am getting the following test
>>>>>> failures:
>>>>>>
>>>>>>
>>>>>> Results :
>>>>>>
>>>>>> Failed tests:
>>>>>>   CustomConfigurationTest.testConfig:61 expected same:<ERROR>
was
>>>>>> not:<INFO>
>>>>>>   FileOutputTest.testConfig:44 File is empty
>>>>>>
>>>>>> Tests run: 543, Failures: 2, Errors: 0, Skipped: 15
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Matt Sicker <boards@gmail.com>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Matt Sicker <boards@gmail.com>
>>>>
>>>
>>>
>>>
>>> --
>>> Matt Sicker <boards@gmail.com>
>>>
>>>
>>>
>>
>>
>> --
>> Matt Sicker <boards@gmail.com>
>>
>
>
>
> --
> Matt Sicker <boards@gmail.com>
>
>
>


-- 
Matt Sicker <boards@gmail.com>

Mime
View raw message