logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remko Popma <remko.po...@gmail.com>
Subject Re: svn commit: r1584469 - /logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
Date Fri, 04 Apr 2014 03:50:05 GMT
Ah I see. I only saw the email, not the source. 
Thanks!

Sent from my iPhone

> On 2014/04/04, at 11:46, Matt Sicker <boards@gmail.com> wrote:
> 
> It's always null due to the null check beforehand.
> 
>> On Thursday, 3 April 2014, Remko Popma <remko.popma@gmail.com> wrote:
>> Matt,
>> In FormattedMessage.writeObject
>> Why did you remove the throwable?
>> 
>> if (message == null) {
>> -            message = getMessage(messagePattern, argArray, throwable);
>> +            message = getMessage(messagePattern, argArray, null);
>>         }
>> 
>>> On Friday, April 4, 2014, <mattsicker@apache.org> wrote:
>>> Author: mattsicker
>>> Date: Thu Apr  3 23:28:55 2014
>>> New Revision: 1584469
>>> 
>>> URL: http://svn.apache.org/r1584469
>>> Log:
>>> Replace single char strings with chars.
>>> 
>>> Modified:
>>>     logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
>>> 
>>> Modified: logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
>>> URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java?rev=1584469&r1=1584468&r2=1584469&view=diff
>>> ==============================================================================
>>> --- logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
(original)
>>> +++ logging/log4j/log4j2/trunk/log4j-api/src/main/java/org/apache/logging/log4j/message/FormattedMessage.java
Thu Apr  3 23:28:55 2014
>>> @@ -164,7 +164,7 @@ public class FormattedMessage implements
>>>      @Override
>>>      public String toString() {
>>>          return "FormattedMessage[messagePattern=" + messagePattern + ", args="
+
>>> -            Arrays.toString(argArray) +  "]";
>>> +            Arrays.toString(argArray) + ']';
>>>      }
>>> 
>>>      private void writeObject(final ObjectOutputStream out) throws IOException
{
>>> @@ -203,7 +203,7 @@ public class FormattedMessage implements
>>>              return throwable;
>>>          }
>>>          if (message == null) {
>>> -            message = getMessage(messagePattern, argArray, throwable);
>>> +            message = getMessage(messagePattern, argArray, null);
>>>          }
>>>          return message.getThrowable();
>>>      }
> 
> 
> -- 
> Matt Sicker <boards@gmail.com>

Mime
View raw message