Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4D92410ADD for ; Mon, 24 Mar 2014 22:35:57 +0000 (UTC) Received: (qmail 14556 invoked by uid 500); 24 Mar 2014 22:35:53 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 14435 invoked by uid 500); 24 Mar 2014 22:35:50 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 14364 invoked by uid 99); 24 Mar 2014 22:35:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Mar 2014 22:35:48 +0000 X-ASF-Spam-Status: No, hits=2.2 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com designates 209.85.192.170 as permitted sender) Received: from [209.85.192.170] (HELO mail-pd0-f170.google.com) (209.85.192.170) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Mar 2014 22:35:42 +0000 Received: by mail-pd0-f170.google.com with SMTP id v10so5986801pde.1 for ; Mon, 24 Mar 2014 15:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=CIDysw15fO76HwgBCE9HCKNJLiIJHrDeYgpiEU5LP98=; b=EVRHGoaa+etLE37g5MlrRlYzvGQU072jzl0mv2OEoQa0bxE2iaohJJx31+YW0z/hsP C2EpiASIZndKgtinTUkEV0T6r/42c85EHFJEr9ebOfXJsdWc70QTh95xMCRXr7p0QL9q kVufZkj+hkRYDylA8qdMPgC8ItmAZVvXnqFYsA5Z7Mj2hUBWld5ZHFO+B9wzSrQ7aAmh vtlXV40iKufAKMRh8P6wjcwAgaJgUILoR/TjwaBzqXB942c1zznwUCEZhKO1BhQ5B914 UtQkdO1p1xmETJLRNyJJRnQ4UfaS7f5R0ZKv+VxOBp6IKe0dDNLfhzp3Hen/RraMLZEu Fzig== MIME-Version: 1.0 X-Received: by 10.66.158.132 with SMTP id wu4mr75109366pab.66.1395700520622; Mon, 24 Mar 2014 15:35:20 -0700 (PDT) Received: by 10.70.30.33 with HTTP; Mon, 24 Mar 2014 15:35:20 -0700 (PDT) In-Reply-To: References: Date: Mon, 24 Mar 2014 18:35:20 -0400 Message-ID: Subject: Re: Rename AbstractLoggerWrapper ? From: Gary Gregory To: Log4J Developers List Content-Type: multipart/alternative; boundary=047d7bacc1a0bea1e104f561d90d X-Virus-Checked: Checked by ClamAV on apache.org --047d7bacc1a0bea1e104f561d90d Content-Type: text/plain; charset=UTF-8 On Mon, Mar 24, 2014 at 3:53 PM, Gary Gregory wrote: > I'll make this change soon unless someone pipes up. > Done. Gary > > Gary > > > On Mon, Mar 24, 2014 at 3:33 PM, Matt Sicker wrote: > >> Being a wrapper class tends to mean concrete in my experience, so it >> would make sense to shorten it to LoggerProviderWrapper. The old >> AbstractLoggerWrapper name would have made more sense as LoggerWrapper >> anyhow (unless it was abstract). >> >> >> On 24 March 2014 01:03, Gary Gregory wrote: >> >>> Also now public class AbstractLoggerProviderWrapper extends >>> AbstractLoggerProvider but it is not abstract. >>> >>> If it is intended to be, let's declare it as such or drop the "Abstract" >>> from the name. >>> >>> Gary >>> >>> >>> On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory wrote: >>> >>>> In the same vein: AbstractLogger -> AbstractLoggerProvider since it >>>> implements LoggerProvider. >>>> >>>> Gary >>>> >>>> >>>> On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker wrote: >>>> >>>>> Sounds like a good idea. >>>>> >>>>> >>>>> On 23 March 2014 21:20, Gary Gregory wrote: >>>>> >>>>>> Now that AbstractLoggerWrapper looks like this: >>>>>> >>>>>> public class AbstractLoggerWrapper extends AbstractLogger { >>>>>> >>>>>> /** >>>>>> * The wrapped Logger. >>>>>> */ >>>>>> protected final LoggerProvider logger; >>>>>> >>>>>> Should rename AbstractLoggerWrapper to LoggerProviderWrapper? >>>>>> >>>>>> Gary >>>>>> >>>>>> -- >>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>>>> Java Persistence with Hibernate, Second Edition >>>>>> JUnit in Action, Second Edition >>>>>> Spring Batch in Action >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Matt Sicker >>>>> >>>> >>>> >>>> >>>> -- >>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>>> Java Persistence with Hibernate, Second Edition >>>> JUnit in Action, Second Edition >>>> Spring Batch in Action >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> E-Mail: garydgregory@gmail.com | ggregory@apache.org >>> Java Persistence with Hibernate, Second Edition >>> JUnit in Action, Second Edition >>> Spring Batch in Action >>> Blog: http://garygregory.wordpress.com >>> Home: http://garygregory.com/ >>> Tweet! http://twitter.com/GaryGregory >>> >> >> >> >> -- >> Matt Sicker >> > > > > -- > E-Mail: garydgregory@gmail.com | ggregory@apache.org > Java Persistence with Hibernate, Second Edition > JUnit in Action, Second Edition > Spring Batch in Action > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org Java Persistence with Hibernate, Second Edition JUnit in Action, Second Edition Spring Batch in Action Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --047d7bacc1a0bea1e104f561d90d Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On M= on, Mar 24, 2014 at 3:53 PM, Gary Gregory <garydgregory@gmail.com= > wrote:
I'll make this cha= nge soon unless someone pipes up.

Done.

Gar= y
=C2=A0
<= span class=3D"HOEnZb">
Gary
=


On Mon, Mar 24, 2014 at 3:33= PM, Matt Sicker <boards@gmail.com> wrote:
Being a wrapper class tends= to mean concrete in my experience, so it would make sense to shorten it to= LoggerProviderWrapper. The old AbstractLoggerWrapper name would have made = more sense as LoggerWrapper anyhow (unless it was abstract).


On = 24 March 2014 01:03, Gary Gregory <garydgregory@gmail.com> wrote:
Also now public class AbstractLoggerProviderWrap= per extends AbstractLoggerProvider but it is not abstract.

If= it is intended to be, let's declare it as such or drop the "Abstr= act" from the name.

Gary


On Mon, Mar 24, 2014 at 1:59 AM, Gary Gregory <garydgregory@gmail= .com> wrote:
In the same vein: Abst= ractLogger -> AbstractLoggerProvider since it implements LoggerProvider.=

Gary


On Mon, Mar 24, 2014 at 12:26 AM, Matt Sicker <boards@gmail.com>= wrote:
Sounds like a good idea.


On 23 March 2014 21:20, Gary Gregory <garydgregory@gmail.com><= /span> wrote:
Now that Abstract= LoggerWrapper looks like this:

public class AbstractLoggerWrapper ex= tends AbstractLogger {

=C2=A0=C2=A0=C2=A0 /**
=C2=A0=C2=A0=C2=A0=C2=A0 * The wrapped Logger= .
=C2=A0=C2=A0=C2=A0=C2=A0 */
=C2=A0=C2=A0=C2=A0 protected final Logg= erProvider logger;

Should rename AbstractLoggerWrapper to LoggerProviderWrapper?

Gary



<= font color=3D"#888888">--
Matt Sicker <boards@gmail.com>



--



--



<= /div>--
Matt Sicker <boards@gmail.com>



--



--
--047d7bacc1a0bea1e104f561d90d--