logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dimitry Declercq (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-407) JDBCAppender cannot recover from loss of database connectivity
Date Wed, 20 Nov 2013 18:08:35 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13827918#comment-13827918
] 

Dimitry Declercq commented on LOG4J2-407:
-----------------------------------------

Michael, I like your idea very much. How we use the Log4J here, is through a fully configured
BoneCP connection pool which indeed already does checking. As you stated, the problem is that
the current implementation just uses a single connection.

I think that in terms of performance it might actually be faster if you implement it so as
it can request multiple connections from a pool for parallel processing. If this isn't possible
you could mitigate performance drawbacks (if any) by using the buffer attribute and only requesting
a new connection from the pool on each buffer iteration.

I'm not sure if a "isPooled" flag would be needed, just close and open a connection by default
and document this behaviour with a addition that a ConnectionPool is strongly required for
intensive logging. I suspect that most enterprise applications or applications generating
lots of data would already use a pool.

I think there are now 2 approaches in this Issue that are under discussion:
- Reconnect on exception/disconnect (as explained by Thomas Neidhart)
- Redo the connection management and open/close on each (batch of) logging event, especially
in the case when a connection pool is used (as explained by Michael Kloster)

I'm more in favor of the second for a long term solution, but as a quickfix I wrote some code
doing the first. I was unable to test my code today, I hope to be able to provide quickfix
by friday (my application needs it bad),

> JDBCAppender cannot recover from loss of database connectivity
> --------------------------------------------------------------
>
>                 Key: LOG4J2-407
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-407
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.0-beta9
>            Reporter: Michael Kloster
>            Assignee: Nick Williams
>
> The JDBCAppender holds a single database connection for all its logging. If that database
connection is closed, it does not attempt to make a new connection.
> Many connection pools automatically close connections after a certain amount of inactivity.
(This can be worked around by properly configuring a pool).
> Database connectivity issues are also common enough that a long running application may
experience temporary network issues. When the network comes back online, the logging will
not resume.
> I've been meaning to submit a patch for this, but I haven't gotten to it. Since I saw
that you are looking to come out of beta soon, I thought I would log this issue in case someone
else has time to write the patch before I get to it.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message