logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: PluginAttr vs. PluginAttribute
Date Thu, 22 Aug 2013 11:22:26 GMT
On Mon, Aug 19, 2013 at 1:42 PM, Ralph Goers <ralph.goers@dslextreme.com>wrote:

> A couple of thoughts.
>
> a) Is PluginAttribute really any clearer than PluginAttr?
> b) Take a look at the SyslogAppender, JMSTopicAppender and some of the
> other ones.  Changing PluginAttr to PluginAttribute adds 5 more characters
> to the lines. That may not seem like much but it forces the arguments to
> JMSTopicAppender to all be shifted to the left to avoid exceeding the line
> length. I'm guessing that if you did this you would probably do a mass
> change. But then you would have to run checkstyle and fix all the classes
> that you just created errors in.
>
> Other than that, if the consensus is to change it I have no objection.
>

Closing the loop: This is in trunk.

Gary


> Raph
>
> On Aug 19, 2013, at 7:56 AM, Gary Gregory wrote:
>
> Hi All:
>
> I think we should rename PluginAttr to PluginAttribute, it is the only
> annotation that is abbreviated in the package. For example, PluginElement
> and PluginConfiguration are not abbreviated.
>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
> Spring Batch in Action <http://www.manning.com/templier/>
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
View raw message