logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remko Popma (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LOG4J2-124) Gracefully stopping LogContext using the api interfaces
Date Sun, 21 Jul 2013 08:28:51 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13714666#comment-13714666
] 

Remko Popma edited comment on LOG4J2-124 at 7/21/13 8:28 AM:
-------------------------------------------------------------

I see, you don't want this method in the LoggerContext interface, good point. 

How about adding a new interface to the SPI package? This interface has only one method, {{void
shutdown()}}. The interface could be called, for example, IShutdown. 
The implementation then would look like this:

{code}
// LogManager
public static void shutdown() {
  LoggerContext context = getContext();
  if (context instanceof IShutdown) {
    ((IShutdown) context).shutdown();
  }
}
{code}

This way it is optional for other LoggerContext implementations to implement the IShutdown
interface. 
                
      was (Author: remkop@yahoo.com):
    I see, you don't want this method in the LoggerContext interface, good point. 

How about adding a new interface to the SPI package? This interface has only one method, {{void
shutdown()}}. The interface could be called, for example, IShutdown. 
The implementation then would look like this:

{code}
// LogManager
public static void shutdown() {
  LoggerContext context = getContext();
  if (context instanceof IShutdown) {
    ((IShutdown) context).shutdown();
  }
}
{code}
                  
> Gracefully stopping LogContext using the api interfaces
> -------------------------------------------------------
>
>                 Key: LOG4J2-124
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-124
>             Project: Log4j 2
>          Issue Type: Question
>    Affects Versions: 2.0-beta3
>            Reporter: Szabolcs Beki
>            Priority: Minor
>
> I'm trying to gracefully close my SocketAppender before exiting the my application to
avoid IOExceptions on the socket server side.  
> Currently I can make it only by using interface the org.apache.logging.log4j.core.Lifecycle
interface in the Log4j2 core  : 
> ((Lifecycle) LogManager.getContext()).stop();
> I would prefer to have a cleaner solution that uses solely the Log4j-api not Log4j-core.

> Did I overlook something or stop() on the API side really missing ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message