Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Subject: Re: [VOTE] Log4j 2.0-beta7 rc2
References: <DB304EBE-21E2-4A63-A739-551CB8E029AE@dslextreme.com>
 <CACZkXPwh0LquRzStom=CXHeG2v00xMXHQjKcFOEquTpYKhTxqA@mail.gmail.com>
 <19F9308E-4405-43A2-A698-228777C8A3D5@nicholaswilliams.net>
 <CACZkXPxiqwPvM7ML083KM9-3fzV7Xrj7e0+SZn_0UrEfZWZpBA@mail.gmail.com>
 <C7DF0A87-0CC4-4F46-9EBB-ABB8543873EE@yahoo.com>
 <8691E817-F4DF-40D1-920E-36F2F9F4A831@dslextreme.com>
From: Remko Popma <remkop@yahoo.com>
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: <8691E817-F4DF-40D1-920E-36F2F9F4A831@dslextreme.com>
Message-Id: <6130CE1F-25E1-4289-BD6D-F5E3376D02F1@yahoo.com>
Date: Tue, 4 Jun 2013 13:48:59 +0900
To: Log4J Developers List <log4j-dev@logging.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)

I see.=20
I was surprised that it only tests the throughput of checking whether a log l=
evel is enabled; I guess I expected something else. Sorry for the knee jerk r=
eaction.=20

I still have ideas to improve some of the implementation mechanics, I'll fol=
low up on them separately.=20

Sent from my iPhone

On 2013/06/04, at 12:49, Ralph Goers <ralph.goers@dslextreme.com> wrote:

> The test really does do what it is supposed to.  If you add some code that=
 causes a minor amount of overhead when logging is disabled this test will f=
ail.  It is there to detect that kind of serious problem.
>=20
> Ralph
>=20
> On Jun 3, 2013, at 7:11 PM, Remko Popma wrote:
>=20
>> I agree with Gary that this test needs some work (or should not be part o=
f the build: a proper performance test needs 5-10 seconds warmup, so these k=
ind of tests end up taking too long to be run together with the functional J=
Unit tests).
>>=20
>> I don't think this test does what it is trying to do. (It won't detect ne=
w performance issues.)
>>=20
>> So I agree with Nick we don't need to treat this as a showstopper.=20
>>=20
>> Remko
>>=20
>> PS
>> FWIW, I cannot reproduce the issue on my PC at work.=20
>>=20
>> PS2=20
>> Cut off lower half of this mail to prevent Apache mailer daemon from boun=
cing my message.=20
>>=20
>> Sent from my iPhone

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org