logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (LOG4J2-277) Wasted work in RollingAppenderSizeTest.testAppender() and other tests
Date Thu, 13 Jun 2013 23:26:20 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Gary Gregory resolved LOG4J2-277.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0-beta8

{noformat}
commit -m "[LOG4J2-277] Wasted work in RollingAppenderSizeTest.testAppender() and others."
(7 paths specified)
    Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderSizeTest.java
    Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeAndSizeTest.java
    Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderTimeTest.java
    Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/appender/rolling/RollingAppenderUncompressedTest.java
    Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/async/perftest/PerfTest.java
    Sending        C:/vcs/svn/apache/log4j2/trunk/core/src/test/java/org/apache/logging/log4j/core/config/AdvertiserTest.java
    Sending        C:/vcs/svn/apache/log4j2/trunk/src/changes/changes.xml
    Transmitting file data ...
    Committed revision 1492902
{noformat}

                
> Wasted work in RollingAppenderSizeTest.testAppender() and other tests
> ---------------------------------------------------------------------
>
>                 Key: LOG4J2-277
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-277
>             Project: Log4j 2
>          Issue Type: Bug
>    Affects Versions: 2.0-beta7
>         Environment: any
>            Reporter: Adrian Nistor
>            Priority: Minor
>              Labels: patch, performance
>             Fix For: 2.0-beta8
>
>         Attachments: patch2.diff, patch3.diff, patch4.diff, patch5.diff, patch6.diff,
patchAll.diff, patch.diff
>
>
> The problem appears in Log4j 2.0-beta7 and in revision 1491481.  I
> attached a one-line patch (patch.diff) that fixes it.  This problem
> and the attached patch are similar to the previously fixed LOG4J2-273
> and LOG4J2-274, and their patches.
> In method "RollingAppenderSizeTest.testAppender", the loop over
> "files" should break immediately after "found" is set to "true".  All
> the iterations after "found" is set to "true" do not perform any
> useful work, at best they just set "found" again to "true".
> Similar problems exist in
> "RollingAppenderTimeAndSizeTest.testAppender",
> "RollingAppenderTimeTest.testAppender",
> "RollingAppenderUncompressedTest.testAppender", "PerfTest.doMain", and
> "AdvertiserTest.verifyExpectedEntriesAdvertised".  I attached patches
> patch2.diff, patch3.diff, patch4.diff, patch5.diff, and patch6.diff
> for these methods.  I also attached a patch (patchAll.diff) that
> aggregates all these changes in one single patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message