logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adrian Nistor (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LOG4J2-273) wasted work in XMLLayout.toSerializable()
Date Thu, 06 Jun 2013 17:49:20 GMT

     [ https://issues.apache.org/jira/browse/LOG4J2-273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adrian Nistor updated LOG4J2-273:
---------------------------------

    Description: 
The problem appears in Log4j 2.0-beta6 and in revision 1490297.  I
attached a one-line patch that fixes it.

In method "XMLLayout.toSerializable", the loop over
"formats" should break immediately after
"xmlSupported" is set to "true".  All the iterations after
"xmlSupported" is set to "true" do not perform any useful work,
at best they just set "xmlSupported" again to "true".

  was:
The problem appears in Log4j 2.0-beta6 and in revision 1490297.  I
attached a one-line patch that fixes it.

In method "XMLLayout.toSerializable", the loop over
"formats" should should break immediately after
"xmlSupported" is set to "true".  All the iterations after
"xmlSupported" is set to "true" do not perform any useful work,
at best they just set "xmlSupported" again to "true".

    
> wasted work in XMLLayout.toSerializable()
> -----------------------------------------
>
>                 Key: LOG4J2-273
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-273
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Layouts
>    Affects Versions: 2.0-beta6
>         Environment: any
>            Reporter: Adrian Nistor
>            Priority: Minor
>              Labels: patch, perfomance
>         Attachments: patch.diff
>
>
> The problem appears in Log4j 2.0-beta6 and in revision 1490297.  I
> attached a one-line patch that fixes it.
> In method "XMLLayout.toSerializable", the loop over
> "formats" should break immediately after
> "xmlSupported" is set to "true".  All the iterations after
> "xmlSupported" is set to "true" do not perform any useful work,
> at best they just set "xmlSupported" again to "true".

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message