logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Tucker (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-248) Log4jContextListener: Use Thread instead of Class for fallback classloader
Date Thu, 09 May 2013 23:44:13 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13653388#comment-13653388
] 

Tim Tucker commented on LOG4J2-248:
-----------------------------------

The warning is actually one of the few in their J2EE ruleset:
http://marc.theaimsgroup.com/?l=struts-user&m=103739031630236&w=4

Interestingly enough, I came across some mention of both approaches in old posts on the Stuts
mailing lists as well:
http://mail-archives.apache.org/mod_mbox/struts-user/200307.mbox/%3C3F1D3C51.2050209@apache.org%3E

(In their case, it looks like they were using Thread.currentThread().getContextClassLoader()
then falling back to the classloader for the class if that returned null).
                
> Log4jContextListener: Use Thread instead of Class for fallback classloader
> --------------------------------------------------------------------------
>
>                 Key: LOG4J2-248
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-248
>             Project: Log4j 2
>          Issue Type: Improvement
>    Affects Versions: 2.0-beta5
>            Reporter: Tim Tucker
>            Priority: Minor
>
> I was experimenting with creating my own context listener based on Log4jContextListener
and noticed that the call in getClassLoader to get the class's classloader was triggering
a PMD warning.
> The rule's notes indicate that Thread.currentThread().getContextClassLoader() might return
more reliable results than Object.class.getClassLoader().
> The code in question is as follows:
> try {
>     // if container is Servlet 3.0, use its getClassLoader method
>     return (ClassLoader)context.getClass().getMethod("getClassLoader").invoke(context);
> } catch (Exception ignore) {
>     // otherwise, use this class's class loader
>     return Log4jContextListener.class.getClassLoader();
> }

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message