logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kurt Lehrke (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-243) LoggerConfig has a method that should be protected instead of private.
Date Wed, 08 May 2013 16:07:15 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13652015#comment-13652015
] 

Kurt Lehrke commented on LOG4J2-243:
------------------------------------

We're overriding createEvent so that we can put some things (specific to our business needs)
into the ThreadContext, and remove it after the call.  This is specific to our needs, and
wouldn't fit into the needs of Log4j.
                
> LoggerConfig has a method that should be protected instead of private.
> ----------------------------------------------------------------------
>
>                 Key: LOG4J2-243
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-243
>             Project: Log4j 2
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.0-beta6
>            Reporter: Kurt Lehrke
>            Priority: Minor
>
> LoggerConfig has a protected constructor that has an argument called includeLocation
(boolean).  When log4j2 calls this constructor they use the private static boolean includeLocation
method to determine this argument.  Since it's private, I cannot call it.  I would like to
suggest this to be changed to a protected method instead.  That way, I don't have to duplicate
the method in order to call this constructor, especially since it's specifically for the protected
constructor.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message