Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0E756FA08 for ; Wed, 3 Apr 2013 16:45:19 +0000 (UTC) Received: (qmail 44990 invoked by uid 500); 3 Apr 2013 16:45:17 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 44669 invoked by uid 500); 3 Apr 2013 16:45:17 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 43549 invoked by uid 99); 3 Apr 2013 16:45:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Apr 2013 16:45:16 +0000 Date: Wed, 3 Apr 2013 16:45:16 +0000 (UTC) From: "Ralph Goers (JIRA)" To: log4j-dev@logging.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (LOG4J2-184) the performance for the log4j initialization needs to be improved MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/LOG4J2-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13621039#comment-13621039 ] Ralph Goers commented on LOG4J2-184: ------------------------------------ I am not sure what your "What do you mean?" question is in reference to. As for the approach to improve performance, the only trouble with what you are suggesting is that it is already implemented. During the build Log4j serializes the Plugin map to a file which is then embedded in the Log4j jar. Somehow, it looks like your application is not finding it. Out of curiousity, if you check out trunk and build it, switch to the log4j-core directory and run "mvn test -Dtest=Log4jInitPerformance" do you get the same results? > the performance for the log4j initialization needs to be improved > ----------------------------------------------------------------- > > Key: LOG4J2-184 > URL: https://issues.apache.org/jira/browse/LOG4J2-184 > Project: Log4j 2 > Issue Type: Bug > Components: Core > Affects Versions: 2.0-beta4 > Reporter: Andreas Rytina > Attachments: Log4j2InitializationPerformanceTest.java > > > The initialization of Log4j 2.0 beta4 via an InputStream takes too long. I attached an small performance test which reproduces the problem. On my machine (Dell Latidude E6530 with an Intel Core i7-3720QM CPU @ 2.6 GHz and 8 GB RAM, OS: Windows 7 64-bit) the test takes approximately one second to complete. On the machine at the customer project, I'm currently working on, it's even worse. > After analyzing this, I found out that the method org.apache.logging.log4j.core.config.plugins.PluginManager.collectPlugins() is called way to often which consumes most time of the initialization! > here the output with status=debug: > 2013-04-01 18:42:37,337 DEBUG Generated plugins in 0.115481476 seconds > 2013-04-01 18:42:37,344 DEBUG Calling createLayout on class org.apache.logging.log4j.core.layout.PatternLayout for element PatternLayout with params(pattern="%m%n", Configuration(ConfigTest), null, charset="null") > 2013-04-01 18:42:37,469 DEBUG Generated plugins in 0.125255928 seconds > 2013-04-01 18:42:37,471 DEBUG Calling createAppender on class org.apache.logging.log4j.core.appender.ConsoleAppender for element Console with params(PatternLayout(%m%n), null, target="null", name="STDOUT", follow="null", suppressExceptions="null") > 2013-04-01 18:42:37,471 DEBUG Jansi is not installed > 2013-04-01 18:42:37,472 DEBUG Calling createAppenders on class org.apache.logging.log4j.core.config.plugins.AppendersPlugin for element appenders with params(appenders={STDOUT}) > 2013-04-01 18:42:37,580 DEBUG Generated plugins in 0.107575072 seconds > 2013-04-01 18:42:37,581 DEBUG Calling createAppenderRef on class org.apache.logging.log4j.core.config.AppenderRef for element appender-ref with params(ref="STDOUT", level="null", null) > 2013-04-01 18:42:37,582 DEBUG Calling createLogger on class org.apache.logging.log4j.core.config.LoggerConfig$RootLogger for element root with params(additivity="null", level="debug", appender-ref={org.apache.logging.log4j.core.config.AppenderRef@39757c6f}, properties={}, Configuration(ConfigTest), null) > 2013-04-01 18:42:37,582 DEBUG Calling createLoggers on class org.apache.logging.log4j.core.config.plugins.LoggersPlugin for element loggers with params(loggers={root}) > log4j 2.0 initialization took 988ms -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org For additional commands, e-mail: log4j-dev-help@logging.apache.org