logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henry Clout (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LOG4J2-173) BurstFilter does not honour level
Date Mon, 22 Apr 2013 10:25:16 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13637897#comment-13637897
] 

Henry Clout edited comment on LOG4J2-173 at 4/22/13 10:23 AM:
--------------------------------------------------------------

Ahh, you're right -- RTFM, Henry.  Apologies for wasting your time on this, Ralph.  

FWIW I achieved my goal (emailing errors, but preventing email flooding) without modifying
the BurstFilter with the following filter configuration :

<filters>
    <ThresholdFilter level="ERROR"/>
    <BurstFilter rate="0.1" maxBurst="5" level="ERROR" />
</filters>

Thanks for looking into this, and apologies again.



                
      was (Author: bighenry):
    Ahh, you're right -- RTFM, Henry.  Apologies for wasting your time on this, Ralph.  

FWIW I achieved my goal (emailing errors, but preventing email flooding) without modifying
the BurstFilter with the following filter configuration :

{code:javascript}
<filters>
    <ThresholdFilter level="ERROR"/>
    <BurstFilter rate="0.1" maxBurst="5" level="ERROR" />
</filters>
{code}

Thanks for looking into this, and apologies again.



                  
> BurstFilter does not honour level
> ---------------------------------
>
>                 Key: LOG4J2-173
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-173
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Filters
>    Affects Versions: 2.0-beta4
>            Reporter: Henry Clout
>         Attachments: BurstFilterTest.java
>
>
> I've been getting info (and below) logging out of the BurstFilter despite it being set
to warn.  The problem seems to be in the filter method, the test :
> if (this.level.isAtLeastAsSpecificAs(level)) {
> ... seems to be the wrong way around.
> I changed the method locally to be:
>     private Result filter(final Level level) {
>         if (level.isAtLeastAsSpecificAs(this.level)) {
>             LogDelay delay = history.poll();
>             while (delay != null) {
>                 available.add(delay);
>                 delay = history.poll();
>             }
>             delay = available.poll();
>             if (delay != null) {
>                 delay.setDelay(burstInterval);
>                 history.add(delay);
>                 return onMatch;
>             }
>             return onMismatch;
>         }
>         return onMismatch;
>     }
> Which seems to have the desired results.
> Does this make sense?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message