logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Scott Severtson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-149) SMTPManager buffer access not synchronized; can result in empty emails
Date Mon, 14 Jan 2013 16:28:12 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13552845#comment-13552845
] 

Scott Severtson commented on LOG4J2-149:
----------------------------------------

But, if .isFiltered returns false, .append is never called. Is there a better place to intercept
*all* messages (only once)?
                
> SMTPManager buffer access not synchronized; can result in empty emails
> ----------------------------------------------------------------------
>
>                 Key: LOG4J2-149
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-149
>             Project: Log4j 2
>          Issue Type: Bug
>          Components: Appenders
>    Affects Versions: 2.0-beta4
>         Environment: N/A
>            Reporter: Scott Severtson
>         Attachments: SMTPManager-buffer-synchronization.patch
>
>
> If multiple error events are logged against the same SMTPAppender/Manager at the same
time, one email will contain both error messages, while the second will be empty (no events).
> The original SMTPAppender patch included synchronization against the CyclicBuffer to
prevent such simultaneous access from multiple threads. This appears to have been lost in
the merge/refactor. Patch (to follow shortly) re-introduces synchronization against the CyclicBuffer
in the narrowest possible scope.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message