logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ralph Goers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LOG4J2-131) Create SMTPAppender
Date Mon, 24 Dec 2012 18:30:12 GMT

    [ https://issues.apache.org/jira/browse/LOG4J2-131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539304#comment-13539304

Ralph Goers commented on LOG4J2-131:

I've spent a couple of hours reviewing the patch and am not going to be able to commit it
as is for the following reasons:
1. The patch seems to require the changes from LOG4j2-136 to cleanly apply. I haven't reviewed
that yet.
2. For some reason you have published the javamail jars to every subproject as an optional
dependency. I'm not sure why that is needed.
3. Using a manager allows multiple appender instances to share resources so that they all
behave as if they were a single appender.  SMTPSessionManager doesn't do that. In fact, it
is only used in a local variable in the factory method.  I would expect that the CyclicBuffer
as well as all the actual work to send the email would be in the Manager.

I plan to refactor your patch to address all of the above.
> Create SMTPAppender
> -------------------
>                 Key: LOG4J2-131
>                 URL: https://issues.apache.org/jira/browse/LOG4J2-131
>             Project: Log4j 2
>          Issue Type: New Feature
>          Components: Appenders
>            Reporter: Christian Grobmeier
>         Attachments: SMTPAppender.patch
> Somebody in twitterverse reverted back to log4j 1.2 because he missed the SMTP Appender

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org

View raw message