logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ralph Goers <ralph.go...@dslextreme.com>
Subject Re: org.apache.logging.log4j.message.MapMessage impl refinement
Date Mon, 01 Oct 2012 16:13:51 GMT
Go for it!

Ralph

On Oct 1, 2012, at 8:44 AM, Gary Gregory wrote:

> Hi All:
> 
> In org.apache.logging.log4j.message.MapMessage, the map is typed as Map<String, String>
but every time we want to do something with it, it is converted to a TreeMap (impls. SortedMap).
> 
> - This is wasteful if the map is already a SortedMap.
> - There is a lot code duplication to create the sorted maps.
> 
> How about adding a SortedMap ctor and converting the passed in map to a TreeMap for other
ctors?
> 
> Gary
> 
> -- 
> E-Mail: garydgregory@gmail.com | ggregory@apache.org 
> JUnit in Action, 2nd Ed: http://bit.ly/ECvg0
> Spring Batch in Action: http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com 
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory


Mime
View raw message