Return-Path: X-Original-To: apmail-logging-log4j-dev-archive@www.apache.org Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 8BF1E9E1B for ; Thu, 15 Mar 2012 15:07:47 +0000 (UTC) Received: (qmail 84529 invoked by uid 500); 15 Mar 2012 15:07:47 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 84482 invoked by uid 500); 15 Mar 2012 15:07:47 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 84472 invoked by uid 99); 15 Mar 2012 15:07:47 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2012 15:07:47 +0000 Received: from localhost (HELO mail-pz0-f46.google.com) (127.0.0.1) (smtp-auth username ggregory, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Mar 2012 15:07:47 +0000 Received: by dajr28 with SMTP id r28so4983358daj.5 for ; Thu, 15 Mar 2012 08:07:46 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.230.133 with SMTP id sy5mr5579176pbc.134.1331824066603; Thu, 15 Mar 2012 08:07:46 -0700 (PDT) Received: by 10.68.216.196 with HTTP; Thu, 15 Mar 2012 08:07:46 -0700 (PDT) In-Reply-To: References: Date: Thu, 15 Mar 2012 11:07:46 -0400 Message-ID: Subject: Re: Lack of Category.error(Throwable t) From: Gary Gregory To: Log4J Developers List Content-Type: multipart/alternative; boundary=047d7b3396db64ac7404bb4974c5 --047d7b3396db64ac7404bb4974c5 Content-Type: text/plain; charset=UTF-8 On Thu, Mar 15, 2012 at 10:55 AM, Christian Grobmeier wrote: > If I understand you right, your suggestion is to add: > error(Throwable t) > I don't see a reason why this cannot happen... > We just should not remove methods to keep bc, but adding should not be a > problem > For 1.4? :) Gary > > Cheers! > Christian > > On Wed, Mar 14, 2012 at 8:09 PM, Rich Midwinter > wrote: > > Hi > > > > > > I note that the following methods exist: > > > > error(Object message) > > > > error(Object message, Throwable t) > > > > > > But this one does not: > > > > error(Throwable t) > > > > > > Although it's absence is implied by the following JavaDoc on the first > > method I referred to: > > > > WARNING Note that passing a Throwable to this method will print the name > of > > the Throwable but no stack trace. To print a stack trace use > > the error(Object, Throwable) form instead. > > > > > > Is there a reason I've overlooked to avoid adding a method that just > takes a > > throwable? It's quite frustrating to find out in production that > someone's > > overlooked this and we've lost a stack trace. The fix often just passes > in > > t.getMessage() anyway. > > > > > > Thanks > > > > Rich > > > > > > > > -- > http://www.grobmeier.de > https://www.timeandbill.de > > --------------------------------------------------------------------- > To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org > For additional commands, e-mail: log4j-dev-help@logging.apache.org > > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --047d7b3396db64ac7404bb4974c5 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Thu, Mar 15, 2012 at 10:55 AM, Christian Grob= meier <grobmeie= r@gmail.com> wrote:
If I understand you right, your suggestion is to add:
error(Throwable=C2=A0t)
I don't see a reason why this cannot happen...
We just should not remove methods to keep bc, but adding should not be a pr= oblem

For 1.4? :)

Gary
=C2=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0pt 0pt 0pt 0.8ex;border-l= eft:1px solid rgb(204,204,204);padding-left:1ex">
Cheers!
Christian

On Wed, Mar 14, 2012 at 8:09 PM, Rich Midwinter
<rich.midwinter@gmail.com> wrote:
> Hi
>
>
> I note that the following methods exist:
>
> error(Object=C2=A0message)
>
> error(Object=C2=A0message, Throwable=C2=A0t)
>
>
> But this one does not:
>
> error(Throwable=C2=A0t)
>
>
> Although it's absence is implied by the following JavaDoc on the f= irst
> method I referred to:
>
> WARNING=C2=A0Note that passing a=C2=A0Throwable=C2=A0to this method wi= ll print the name of
> the=C2=A0Throwable=C2=A0but no stack trace. To print a stack trace use=
> the=C2=A0error(Object, Throwable)=C2=A0form instead.
>
>
> Is there a reason I've overlooked to avoid adding a method that ju= st takes a
> throwable? It's quite frustrating to find out in production that s= omeone's
> overlooked this and we've lost a stack trace. The fix often just p= asses in
> t.getMessage() anyway.
>
>
> Thanks
>
> Rich
>
>



--
http://www.grobmeier.= de
https://www.timean= dbill.de

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org




--
E-Mail: <= a href=3D"mailto:garydgregory@gmail.com" target=3D"_blank">garydgregory@gma= il.com | ggreg= ory@apache.org
JUnit in Action, 2nd Ed: = http://bit.ly/ECvg0
Spring Batch in Action: http://bit.ly/bqpbCK
Blo= g: http://g= arygregory.wordpress.com
Home: http://garygreg= ory.com/
Tweet! http://twitter.com/GaryGregory
--047d7b3396db64ac7404bb4974c5--