logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rgo...@apache.org
Subject svn commit: r949482 - in /logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j: Logger.java spi/AbstractLogger.java
Date Sun, 30 May 2010 06:52:39 GMT
Author: rgoers
Date: Sun May 30 06:52:38 2010
New Revision: 949482

URL: http://svn.apache.org/viewvc?rev=949482&view=rev
Log:
Convert @doubt to Jira.

Modified:
    logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Logger.java
    logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java

Modified: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Logger.java
URL: http://svn.apache.org/viewvc/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Logger.java?rev=949482&r1=949481&r2=949482&view=diff
==============================================================================
--- logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Logger.java
(original)
+++ logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/Logger.java
Sun May 30 06:52:38 2010
@@ -21,9 +21,8 @@ import org.apache.logging.log4j.message.
 /**
  * This is the central interface in the log4j package. Most logging
  * operations, except configuration, are done through this interface.
- * @doubt interface so complicated indepenent implementation unlikely.  Should be refactored.
 LogMF/LogSF is a start as it moves message formatting out of logger.
- * @doubt I'd prefer an abstract user context object over Marker.  You could still use a
Marker as your user context object,
- *  but you could also use an HttpServletRequest or any other context object. 
+ * @doubt See LOG4J2-39.
+ * @doubt See LOG4J2-16.
  */
 public interface Logger {
 
@@ -38,7 +37,7 @@ public interface Logger {
   /**
    * Log entry to a method.
    * @param params The parameters to the method.
-   * @doubt Use of varargs results in array creation which can be a substantial portion of
no-op case.  
+   * @doubt Use of varargs results in array creation which can be a substantial portion of
no-op case.
    * LogMF/LogSF provides several overrides to avoid vararg except in edge cases.
    */
   void entry(Object... params);

Modified: logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
URL: http://svn.apache.org/viewvc/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java?rev=949482&r1=949481&r2=949482&view=diff
==============================================================================
--- logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
(original)
+++ logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers/log4j2-api/src/main/java/org/apache/logging/log4j/spi/AbstractLogger.java
Sun May 30 06:52:38 2010
@@ -25,8 +25,7 @@ import org.apache.logging.log4j.message.
 import org.apache.logging.log4j.message.SimpleMessage;
 
 /**
- * @doubt See comments on Logger, interface is so complex that unlikely to be independently
implemented.
- *  LogMF/LogSF separates those concerns out of Logger.
+ * @doubt See Jira LOG4J2-39.
  */
 public abstract class AbstractLogger implements Logger {
 



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message