logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44308] [Patch] JMX component for managing Logger configurations
Date Fri, 14 Mar 2008 02:11:48 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=44308





--- Comment #6 from Paul Smith <psmith@apache.org>  2008-03-13 19:11:47 PST ---
(In reply to comment #5)
> 
> > LoggerManagerModelMBean
> > 	+        try {
> > 	+            getDelegate().getClass().getMethod("rollbackLogConfiguration",
> null);
> > 	+            modelMBeanOperations.add(rollbackLogConfiguration);
> > 	+        } catch (NoSuchMethodException expected) {
> > 	+            // nothing to do
> > 	+        }
> > 	This seems a bit of a hack! :)   Given RollbackableLoggerManager extends 
> >       from LoggerManager, perhaps the same thought could be done to having a
> >       second RollbackableLoggerManagerModelMBean that has a 
> >       doPostRegisterOtherSchtuff() style methods.
> 
> You got me there. :-)
> That really is a hack.
> RollbackableLoggerManagerModelMBean could easily override
> createModelMBeanOperationInfos of LoggerManagerModelMBean which would
> not register that method.
> 
> Thanks a lot for your kind review.

Stefan, do you a newer patch available that addresses this point?  I'd be up
for applying this if this particular item was addressed.

If you were also interested, 

https://issues.apache.org/bugzilla/show_bug.cgi?id=40246

May well also fit within this scope (and possibly easy to do?).  I couldn't get
my local application to do the deRegister, perhaps you would have more success?


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message