DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44109>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=44109
------- Additional Comments From daniel.armbrust.list@gmail.com 2008-01-17 11:06 -------
I'm not sure where you put the null check - Just to be clear - I think that the
null check needs to be in the class above the TelnetAppender - not in the
TelnetAppender itself. The append() sequence should never throw an error that
it caused (for whatever reason) back out to the app that was just trying to log
a message.
So, no matter how poor of an Appender I create, if it messes up and takes a
runtime exception, that shouldn't bubble back out to the caller.
Second, and I should have opened another bug on this, is the issue of creating
the SocketAppender and finding out about errors where the port couldn't be opened.
I fixed this by making the TelnetAppender constructor take in a port number, and
run the code that is currently run in activateOptions. This way, the
constructor can throw the port in use exception back to the caller. I removed
the setPort method, and made the activate options method do nothing.
I can post the full TelnetAppender class, if you like, which fixes this startup
issue, and bug 44108.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org
|