logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 40066] - RollingFileAppender rollover does not work when gaps are present in the files
Date Fri, 02 Mar 2007 09:36:13 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=40066>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40066





------- Additional Comments From yves.debilloez@kbc.be  2007-03-02 01:36 -------
(In reply to comment #1)
> Possibly duplicate of 41735.  Could you test and confirm?

It does seem to be closely related enough and could be closed.
I do not agree however with the suggested change for 41735 and do believe that 
my suggested change could still be an improvement.

I will not update 47135 as it is already marked resolved and put my comments 
here:

Problem 1: you are deleting the last index when you start rolling over.  If 
lastindex is e.g. .10, and you have no .9, there is no reason to delete .10.  
The test for deletion of the last file should be placed when you need this 
name for putting the .9 file only.  That is why I removed these lines and 
added the test for the other renames.

Problem 2: for all renames, you are not testing if the target file exists, as 
such a rename will fail when the file has e.g. read-only marks or is open in a 
non-exclusive mode.  First deleting it avoid pending locks.  e.g. virus 
scanner might be scanning the file but without placing a lock

PS: The problem I reported is that the files are not being locked by the 
system because no other process is accessing the files.  It could be that 
writing to the files occurs concurrently from different threads in the 
application all using the same logging sub-system.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message