Return-Path: Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: (qmail 2495 invoked from network); 1 Aug 2006 19:15:43 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 1 Aug 2006 19:15:43 -0000 Received: (qmail 94074 invoked by uid 500); 1 Aug 2006 19:15:43 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 93827 invoked by uid 500); 1 Aug 2006 19:15:42 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 93816 invoked by uid 500); 1 Aug 2006 19:15:42 -0000 Received: (qmail 93813 invoked by uid 99); 1 Aug 2006 19:15:42 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 12:15:42 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 Aug 2006 12:15:41 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 3CE2C1A981A; Tue, 1 Aug 2006 12:15:21 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r427681 - /logging/log4j/branches/v1_2-branch/src/java/org/apache/log4j/RollingFileAppender.java Date: Tue, 01 Aug 2006 19:15:20 -0000 To: log4j-cvs@logging.apache.org From: carnold@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060801191521.3CE2C1A981A@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: carnold Date: Tue Aug 1 12:15:20 2006 New Revision: 427681 URL: http://svn.apache.org/viewvc?rev=427681&view=rev Log: Bug 31003: RollingFileAppender, if removed, can cause null pointer exceptions Modified: logging/log4j/branches/v1_2-branch/src/java/org/apache/log4j/RollingFileAppender.java Modified: logging/log4j/branches/v1_2-branch/src/java/org/apache/log4j/RollingFileAppender.java URL: http://svn.apache.org/viewvc/logging/log4j/branches/v1_2-branch/src/java/org/apache/log4j/RollingFileAppender.java?rev=427681&r1=427680&r2=427681&view=diff ============================================================================== --- logging/log4j/branches/v1_2-branch/src/java/org/apache/log4j/RollingFileAppender.java (original) +++ logging/log4j/branches/v1_2-branch/src/java/org/apache/log4j/RollingFileAppender.java Tue Aug 1 12:15:20 2006 @@ -118,7 +118,9 @@ File target; File file; - LogLog.debug("rolling over count=" + ((CountingQuietWriter) qw).getCount()); + if (qw != null) { + LogLog.debug("rolling over count=" + ((CountingQuietWriter) qw).getCount()); + } LogLog.debug("maxBackupIndex="+maxBackupIndex); // If maxBackups <= 0, then there is no file renaming to be done. --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org For additional commands, e-mail: log4j-dev-help@logging.apache.org