logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Curt Arnold <carn...@apache.org>
Subject Re: svn commit: r391905 - in /logging/log4j/trunk: docs/ src/java/org/apache/log4j/ src/java/org/apache/log4j/joran/ src/java/org/apache/log4j/spi/ src/java/org/apache/log4j/watchdog/ src/java/org/apache/log4j/xml/ tests/input/watchdog/ tests/src/java/org/
Date Thu, 06 Apr 2006 14:55:07 GMT

On Apr 6, 2006, at 12:36 AM, Mark Womack wrote:

> I checked in a bunch of changes.  Hopefully it isn't more broken  
> than before.  The tests for FileWatchdog are just too intricate.   
> The config file could be getting read by watchdog, so can't be  
> deleted as required in the tests, so I had to add some code to loop  
> on deleting.  Then it seems that it can take some time for the  
> appender buffer to flush to the file, etc.  Most of this intricacy  
> is because of the nature of the test.  In real world usage I don't  
> think it would be this complex.
>
> We'll see if Gump complains tonight.
>
> -Mark


Also, I'm not sure how the FileWatchdog stuff would interact with  
restoring DOMConfigurator for log4j 1.2 compatibility (http:// 
issues.apache.org/bugzilla/show_bug.cgi?id=39024).

configureAndWatch has some very peculiar behavior and I don't think  
it will carry over into log4j 2.0.  So perhaps, restoring the 1.2  
DOMConfigurator and omitting configureAndWatch from JoranConfigurator  
would make all the FileWatchdog stuff moot.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


Mime
View raw message