Return-Path: Delivered-To: apmail-logging-log4j-dev-archive@www.apache.org Received: (qmail 83648 invoked from network); 6 Jan 2005 22:14:26 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 6 Jan 2005 22:14:26 -0000 Received: (qmail 43125 invoked by uid 500); 6 Jan 2005 22:14:25 -0000 Delivered-To: apmail-logging-log4j-dev-archive@logging.apache.org Received: (qmail 43095 invoked by uid 500); 6 Jan 2005 22:14:25 -0000 Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@logging.apache.org Received: (qmail 43081 invoked by uid 99); 6 Jan 2005 22:14:25 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from gulcu002.worldcom.ch (HELO mail.qos.ch) (212.74.184.210) by apache.org (qpsmtpd/0.28) with ESMTP; Thu, 06 Jan 2005 14:14:24 -0800 Received: from kal.qos.ch (kal [192.168.1.3]) by mail.qos.ch (Postfix) with ESMTP id 655A41EC073 for ; Thu, 6 Jan 2005 23:25:47 +0100 (CET) Message-Id: <6.0.3.0.0.20050106230856.039f7dc0@mail.qos.ch> X-Sender: ceki@mail.qos.ch (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 6.0.3.0 Date: Thu, 06 Jan 2005 23:15:24 +0100 To: "Log4J Developers List" From: Ceki =?iso-8859-1?Q?G=FClc=FC?= Subject: Re: [POLL] Component and ComponentBase In-Reply-To: References: <41DB0562.3020508@aconex.com> <0I9W00244NU4SW@mailsj-v1.corp.adobe.com> <6.0.3.0.0.20050106181927.03668950@mail.qos.ch> <41DD99B8.60306@aconex.com> <6.0.3.0.0.20050106215126.03368858@mail.qos.ch> <41DDA7E5.3020106@aconex.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N At 11:02 PM 1/6/2005, Curt Arnold wrote: >Would like Appender and other existing interfaces to NOT extend=20 >LoggerRepositoryAware. > >I'd still like to see LoggerRepositoryAware disappear in favor of passing= =20 >in the LoggerRepository in the constructor, but would not do that just at= =20 >this moment. This reminds me of "Forms Of Dependency Injection" http://www.martinfowler.com/articles/injection.html#FormsOfDependencyInjecti= on >The implementation of setLoggerRepository should allow multiple calls as=20 >long as the repository doesn't change. That is: > >-if (this.repository =3D=3D null) >+if(this.repository =3D=3D null || this.repository =3D=3D repository) Very good point. --=20 Ceki G=FClc=FC The complete log4j manual: http://www.qos.ch/log4j/ --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org For additional commands, e-mail: log4j-dev-help@logging.apache.org