Mailing-List: contact log4j-dev-help@logging.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@logging.apache.org>
Received-SPF: pass (hermes.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Date: Fri, 07 Jan 2005 11:50:44 -0800
From: Mark Womack <womack@adobe.com>
Subject: RE: [NEWS] Component and ComponentBase
In-reply-to: <6.0.3.0.0.20050107182730.03937ff8@mail.qos.ch>
To: "'Log4J Developers List'" <log4j-dev@logging.apache.org>
Reply-to: womack@adobe.com
Message-id: <0I9Y0096EPSKHO@mailsj-v1.corp.adobe.com>
Organization: Adobe Systems
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-transfer-encoding: quoted-printable
Thread-index: AcT0709rDiMYQBLXQv+k7LwgSQvS2QAAlN6w

Which item is this in Effective Java?  He also makes a strong argument =
(Item
1) to use static factory methods instead of constructors.

I think that going down the constructor path can potentially lead to
"parameter madness" as you add more "required" members that must be set =
at
construction time.

Just a comment,
-Mark

> -----Original Message-----
> From: Ceki G=FClc=FC [mailto:ceki@qos.ch]
> Sent: Friday, January 07, 2005 11:31 AM
> To: Log4J Developers List
> Subject: [NEWS] Component and ComponentBase
>=20
>=20
> Curt et al.,
>=20
> I had a long technical dicussion with a friend who mentioned that in
> "Effective Java" Joshua Bloch makes a compelling case against the
> setter approach (and in favor of constructors).
>=20
> The existing configuration code relies on Appenders, Layouts and
> Receivers having a default constructor. However, the Component
> interface and ComponentBase class do *not* prevent the use of
> constructors taking an LR as argument in other classes, in particular
> in the classes indirectly instanciated by Appenders, Layouts, etc.
>=20
> He also suggested a simple solution to the "default repository
> configuration while in the context of 'myWebApp'" problem which
> triggered all the recent changes. Basically, he suggests that in the
> static initializer of LogManager the default repository be configured
> before the repositorySelector is instantiated. During the
> configuration of the default repository, the repositorySelector
> field has to temporarily point to a default RepositorySelector, not
> the real selector, not yet instantiated.
>=20
> This fix may imply that we can go back to the old internal logging
> guidelines which only required instance Logger variables, without the
> need to change every single class that log4j used internally.
>=20
> --
> Ceki G=FClc=FC
>=20
>    The complete log4j manual: http://www.qos.ch/log4j/
>=20
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
> For additional commands, e-mail: log4j-dev-help@logging.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org