Mailing-List: contact log4j-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@jakarta.apache.org>
Message-Id: <5.2.1.1.0.20031203200558.02d508b8@mail.qos.ch>
Date: Wed, 03 Dec 2003 20:07:04 +0100
To: "Log4J Developers List" <log4j-dev@jakarta.apache.org>
From: Ceki =?iso-8859-1?Q?G=FClc=FC?= <ceki@qos.ch>
Subject: Re: LoggingEvent - equals and hashCode
In-Reply-To: <984A7225EFC7FD44B0B66D3A29A144002F9F16@pdxcorp1.vwsnet.com
 >
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; format=flowed
Content-Transfer-Encoding: quoted-printable


I'll add the equals and hashcode methods within the hour or so. Is that OK?

At 10:14 AM 12/3/2003 -0800, Scott Deboy wrote:
>Had an issue yesterday with Chainsaw loading duplicate events.
>
>Our cyclicbuffer stores loggingevents, and was performing a 'contains'
>check on the list to prevent duplicate events from being added
>(duplicates could exist if an xml log file was loaded twice or if the
>events came from jdk1.4 logging, for example).
>
>Of course, the contains check always returned false since the receiver
>reconstructs the loggingevent from the xml representation and
>LoggingEvent doesn't implement equals.
>
>I worked around it by storing a hashset of the event's ID in the model.
>Duplicates show up if the events were loaded from xml or over the wire
>from jdk1.4 logging.
>
>I know we've discussed this on the list before, but could we resolve
>this?  If we plan on supporting the ability to add LoggingEvents to a
>collection, we need to implement equals and hashCode.
>
>As I looked at it, one of the more prominent issues was the
>throwableinfo either being a throwable or a string[].
>
>Opinions?  Can we get resolution on this issue?
>
>Thanks,
>
>Scott

--=20
Ceki G=FClc=FC

      For log4j documentation consider "The complete log4j manual"
      ISBN: 2970036908 http://www.qos.ch/shop/products/clm_t.jsp =20


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: log4j-dev-help@jakarta.apache.org