Mailing-List: contact log4j-dev-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Log4J Developers List" <log4j-dev@jakarta.apache.org>
Message-Id: <5.2.0.9.0.20030218190707.022a4e10@mail.qos.ch>
Date: Tue, 18 Feb 2003 19:24:29 +0100
To: "Log4J Developers List" <log4j-dev@jakarta.apache.org>
From: Ceki =?iso-8859-1?Q?G=FClc=FC?= <ceki@qos.ch>
Subject: RE: Possible 1.2.8 release
In-Reply-To: <F73733CC5E11D41189E700D0B74A0C9E0529F5E5@exchange.bevocal.
 com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"; format=flowed
Content-Transfer-Encoding: quoted-printable


Given that the existing JDBCAppender has other serious problems, I think=20
fixing 14827 is a waste of time. In any case, I won't stand in your way.

The following patch is likely to fix the problem.

Index: src/java/org/apache/log4j/jdbc/JDBCAppender.java
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file:=20
/home/cvs/jakarta-log4j/src/java/org/apache/log4j/jdbc/JDBCAppender.java,v
retrieving revision 1.6.2.2
diff -u -u -r1.6.2.2 JDBCAppender.java
--- src/java/org/apache/log4j/jdbc/JDBCAppender.java    12 Jun 2002=20
21:29:57 -0000      1.6.2.2
+++ src/java/org/apache/log4j/jdbc/JDBCAppender.java    18 Feb 2003=20
18:23:29 -0000
@@ -241,6 +241,7 @@
        }
      }
      buffer.removeAll(removes);
+    removes.clear();
      //buffer.clear();
    }


At 10:06 18.02.2003 -0800, you wrote:
>What about 14827/16998?  Even if we are not going to use this class long
>term, it does have a serious memory leak, discovered by several people.
>Whether we like it or not, this appender seems popular.  I vote to fix it.
>
>-Mark
>
> > -----Original Message-----
> > From: Ceki G=FClc=FC [mailto:ceki@qos.ch]
> > Sent: Tuesday, February 18, 2003 8:58 AM
> > To: Log4J Developers List
> > Subject: RE: Possible 1.2.8 release
> >
> >
> > At 20:54 16.02.2003 -0800, you wrote:
> > >I did a quick review of open bugs.  Besides the fix for
> > #12366, I think we
> > >should consider fixes for:
> > >
> > >14827/16998 - JDBCAppender memory leak.
> >
> >
> >
> > >11570/16170 - Null Pointer Exception in XMLLayout.
> >
> > Bugs 11570/16170 fixed. As well as 15599 reported by Scott Schram.
> > The EntityResolve bug was fixed some time ago. Unless there is an
> > objection, I will make a 1.2.8 release within the next few hours.
> >
> > Is there anything else?
> >
> > >I'll help with applying fixes if agreed.
> > >
> > >-Mark
> > >
> > > >--
> >
> > Ceki
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: log4j-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: log4j-dev-help@jakarta.apache.org
> >
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: log4j-dev-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: log4j-dev-help@jakarta.apache.org

--
Ceki=20


---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: log4j-dev-help@jakarta.apache.org