Return-Path: Delivered-To: apmail-jakarta-log4j-dev-archive@apache.org Received: (qmail 83806 invoked from network); 10 Feb 2003 15:58:49 -0000 Received: from exchange.sun.com (192.18.33.10) by daedalus.apache.org with SMTP; 10 Feb 2003 15:58:49 -0000 Received: (qmail 26323 invoked by uid 97); 10 Feb 2003 16:00:21 -0000 Delivered-To: qmlist-jakarta-archive-log4j-dev@nagoya.betaversion.org Received: (qmail 26316 invoked from network); 10 Feb 2003 16:00:20 -0000 Received: from daedalus.apache.org (HELO apache.org) (208.185.179.12) by nagoya.betaversion.org with SMTP; 10 Feb 2003 16:00:20 -0000 Received: (qmail 82854 invoked by uid 500); 10 Feb 2003 15:58:34 -0000 Mailing-List: contact log4j-dev-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Log4J Developers List" Reply-To: "Log4J Developers List" Delivered-To: mailing list log4j-dev@jakarta.apache.org Received: (qmail 82806 invoked from network); 10 Feb 2003 15:58:33 -0000 Received: from lsne-catv-dhcp-43-104.urbanet.ch (HELO mail.qos.ch) (80.238.43.104) by daedalus.apache.org with SMTP; 10 Feb 2003 15:58:33 -0000 Received: from eitan.qos.ch (eitan [192.168.1.4]) by mail.qos.ch (Postfix) with ESMTP id A9FA315E401 for ; Mon, 10 Feb 2003 16:59:33 +0100 (CET) Message-Id: <5.2.0.9.0.20030210165210.02068eb0@mail.qos.ch> X-Sender: ceki@mail.qos.ch (Unverified) X-Mailer: QUALCOMM Windows Eudora Version 5.2.0.9 Date: Mon, 10 Feb 2003 16:58:34 +0100 To: "Log4J Developers List" From: Ceki =?iso-8859-1?Q?G=FClc=FC?= Subject: Re: RepositorySelector interface design question... In-Reply-To: <5.2.0.9.2.20030210084122.0345fd40@cismail.creativeis.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N You can move the contents of ContextClassLoaderSelector.doIdempotentInitialization method to InitContextListener. There is no need to change the RepositorySelector interface. At 08:53 10.02.2003 -0600, you wrote: >I am wondering what direction I should go to try to genericise the >configuration of custom repository selectors in the servlet/listener >code. See this message for info on the current discussion... >http://marc.theaimsgroup.com/?l=log4j-dev&m=104335006426248&w=2 > > >Specifically, I'm wondering if using a factory to configure custom >repository selectors would be a good idea. It would make it so that the >existing InitServlet and InitContextListener classes wouldn't have to >directly refer to ContextClassLoaderSelector. This is important because >people should be able to choose the repository selector they like best (as >long as one hasn't already been loaded by log4j). The only way I can >think of allowing for this is adding doIdempotentInitialization() to the >RepositorySelector interface so that I can be assured that any class that >claims to be a RepositorySelector will contain this method. > >Is that the right way to go or will this break compatibility with too many >existing classes implementing RepositorySelector? What is another >direction I might take? I'd like to nail this design decision down soon >so that I can continue work on making the initialization stuff more generic. > >thanks, > >Jake > > >--------------------------------------------------------------------- >To unsubscribe, e-mail: log4j-dev-unsubscribe@jakarta.apache.org >For additional commands, e-mail: log4j-dev-help@jakarta.apache.org > -- Ceki --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscribe@jakarta.apache.org For additional commands, e-mail: log4j-dev-help@jakarta.apache.org