logging-log4j-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael A. McAngus" <...@infinet.com>
Subject Re: [SUBMIT] Timezone support for date elements of pattern layout
Date Thu, 18 Jul 2002 02:54:09 GMT
Michael A. McAngus wrote:
> mwomack@apache.org wrote:
> 
>> - "<li>Any pattern accpetible", should be "acceptible".
> 
> 
> Actually, should be "acceptable".  I'll fix this and submit a revised 
> source tonight.

...

>> AbsoluteDateFormat.java
...
>>
>> - I don't see where AbsoluteTimeDateFormat(TimeZone) is deprecated.  It
>> appears to be gone.
>>
>> -----
>> ISO8601DateFormat.java
>>
>> - I don't see where ISO8601DateFormat(TimeZone) is deprecated.  It 
>> appears
>> to be gone.
>>
>> -----
>> DateTimeDateFormat.java
>>
>> - I don't see where DateTimeDateFormat(TimeZone) is deprecated.  It 
>> appears
>> to be gone.
>>
> 
> I really have no idea how that happened.  I know I deprecated those 
> methods.  OK, I'll add them back and deprecate them.
> 
>> -----
>> PatternLayoutTestCase.java
>>
>> - I got the following message reported when the test case started:
>>
>> "D" is not a valid decimal seperator
>> Using Local defined decimal seperator
> 
> 
> Yep.  That's a successful test :-)
> Or are you pointing out that "seperator" should be "separator"?  Another 
> typo to fix.
> This is a LogLog.error message letting the user know that there is a 
> problem in the configuration file.
> 

...

>> -----
>> AbsoluteTimeDateFormatTestCase.java
>>
>> - I get the following error reported when the test case starts:
>>
>> "X" is not a valid decimal seperator
>> etc
> 
> 
> Yep.  Another successful test (except for "seperator").  Negative tests 
> are just as important as positive tests.
> 

Actually, the message says "separator", so no change was needed.


Fixes have been made, see the attached zip file containing updated 
source and new diffs.

-- 
Cheers,
Mike McAngus
mam@infinet.com

Mime
View raw message