Return-Path: Delivered-To: apmail-logging-log4cxx-dev-archive@www.apache.org Received: (qmail 72272 invoked from network); 6 Oct 2005 17:11:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 6 Oct 2005 17:11:16 -0000 Received: (qmail 25311 invoked by uid 500); 6 Oct 2005 17:11:15 -0000 Delivered-To: apmail-logging-log4cxx-dev-archive@logging.apache.org Received: (qmail 25218 invoked by uid 500); 6 Oct 2005 17:11:14 -0000 Mailing-List: contact log4cxx-dev-help@logging.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Log4CXX Dev" List-Id: Delivered-To: mailing list log4cxx-dev@logging.apache.org Received: (qmail 25207 invoked by uid 99); 6 Oct 2005 17:11:14 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2005 10:11:14 -0700 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=HTML_50_60,HTML_MESSAGE,RCVD_BY_IP,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of idispatch@gmail.com designates 64.233.184.197 as permitted sender) Received: from [64.233.184.197] (HELO wproxy.gmail.com) (64.233.184.197) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Oct 2005 10:11:17 -0700 Received: by wproxy.gmail.com with SMTP id 68so225169wri for ; Thu, 06 Oct 2005 10:10:51 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:references; b=kwablRYGJuqJ43C+q+8Vk/BhZIktjQ6ijgWylZqO1+bU0Epym6yYe8Ndpebyn6O6SVQg13Jo9ED0lymIvKkHf3X8axXm+IHRj5BaKXO1xNOORT8L3DS9QAfxbYBloKpbtZaY0C8Mojyt3LjMW62YV7D5IamGDFT1Z/CISVvTSe8= Received: by 10.54.143.3 with SMTP id q3mr1415685wrd; Thu, 06 Oct 2005 10:10:51 -0700 (PDT) Received: by 10.54.101.10 with HTTP; Thu, 6 Oct 2005 10:10:51 -0700 (PDT) Message-ID: Date: Thu, 6 Oct 2005 10:10:51 -0700 From: Josh Clark Reply-To: Josh Clark To: Log4CXX Dev Subject: Re: cvs commit: logging-log4cxx/src odbcappender.cpp In-Reply-To: <20051003025955.74057.qmail@minotaur.apache.org> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_12881_15902284.1128618651758" References: <20051003025955.74057.qmail@minotaur.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N ------=_Part_12881_15902284.1128618651758 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline You are returning true from a function defined to return void. josh On 3 Oct 2005 02:59:55 -0000, carnold@apache.org wrote= : > > carnold 2005/10/02 19:59:55 > > Modified: src odbcappender.cpp > Log: > LOGCXX-104: ODBCAppender::close does not check if appender is already > closed > > Revision Changes Path > 1.16 +4 -1 logging-log4cxx/src/odbcappender.cpp > > Index: odbcappender.cpp > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > RCS file: /home/cvs/logging-log4cxx/src/odbcappender.cpp,v > retrieving revision 1.15 > retrieving revision 1.16 > diff -u -r1.15 -r1.16 > --- odbcappender.cpp 4 May 2005 16:13:41 -0000 1.15 > +++ odbcappender.cpp 3 Oct 2005 02:59:55 -0000 1.16 > @@ -1,5 +1,5 @@ > /* > - * Copyright 2003,2004 The Apache Software Foundation. > + * Copyright 2003,2005 The Apache Software Foundation. > * > * Licensed under the Apache License, Version 2.0 (the "License"); > * you may not use this file except in compliance with the License. > @@ -198,6 +198,9 @@ > > void ODBCAppender::close() > { > + if (closed) { > + return true; > + } > try > { > flushBuffer(); > > > > ------=_Part_12881_15902284.1128618651758 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline You are returning true from a function defined to return void.


josh

On 3 Oct 2005 02:59:55 -0000, = carnold= @apache.org <carnold@apach= e.org > wrote:
carnold     2005/10/02 19:59:55

  = ;Modified:    src      od= bcappender.cpp
  Log:
  LOGCXX-104: ODBCAppender::close does no= t check if appender is already closed

  Revision &nbs= p;Changes    Path
  1.16   =    +4 -1      logging-log4cxx/= src/odbcappender.cpp

  Index: odbcappender.cpp
  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
&n= bsp; RCS file: /home/cvs/logging-log4cxx/src/odbcappender.cpp,v
&nb= sp; retrieving revision 1.15
  retrieving revision 1.16  diff -u -r1.15 -r1.16
  --- odbcappender.cpp  4 May 2005 16:13:41 -0000&n= bsp;      1.15
  +++ odbcappender.cpp=   3 Oct 2005 02:59:55 -0000       1= .16
  @@ -1,5 +1,5 @@
   /*
  - * Co= pyright 2003,2004 The Apache Software Foundation.
  + * Copyright 2003,2005 The Apache Software Foundation.
&nbs= p;   *
    * Licensed under the Apach= e License, Version 2.0 (the "License");
   &nbs= p;* you may not use this file except in compliance with the License.
  @@ -198,6 +198,9 @@

   void ODBCAppender::= close()
   {
  +   if (closed) {
&nb= sp; +       return true;
  = +   }
      try
  &= nbsp;   {
        = ; flushBuffer();




------=_Part_12881_15902284.1128618651758--