logging-log4cxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Clark <idispa...@gmail.com>
Subject Re: cvs commit: logging-log4cxx/src odbcappender.cpp
Date Thu, 06 Oct 2005 17:10:51 GMT
You are returning true from a function defined to return void.


josh

On 3 Oct 2005 02:59:55 -0000, carnold@apache.org <carnold@apache.org> wrote:
>
> carnold 2005/10/02 19:59:55
>
> Modified: src odbcappender.cpp
> Log:
> LOGCXX-104: ODBCAppender::close does not check if appender is already
> closed
>
> Revision Changes Path
> 1.16 +4 -1 logging-log4cxx/src/odbcappender.cpp
>
> Index: odbcappender.cpp
> ===================================================================
> RCS file: /home/cvs/logging-log4cxx/src/odbcappender.cpp,v
> retrieving revision 1.15
> retrieving revision 1.16
> diff -u -r1.15 -r1.16
> --- odbcappender.cpp 4 May 2005 16:13:41 -0000 1.15
> +++ odbcappender.cpp 3 Oct 2005 02:59:55 -0000 1.16
> @@ -1,5 +1,5 @@
> /*
> - * Copyright 2003,2004 The Apache Software Foundation.
> + * Copyright 2003,2005 The Apache Software Foundation.
> *
> * Licensed under the Apache License, Version 2.0 (the "License");
> * you may not use this file except in compliance with the License.
> @@ -198,6 +198,9 @@
>
> void ODBCAppender::close()
> {
> + if (closed) {
> + return true;
> + }
> try
> {
> flushBuffer();
>
>
>
>

Mime
View raw message