logging-log4cxx-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andreas Fester <Andreas.Fes...@gmx.de>
Subject Re: [PATCH][RFC] fix 64bit log4cxx_intptr_t
Date Sat, 29 Oct 2005 11:04:04 GMT
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I have investigated a more portable way of getting rid
of the warning on AMD64 regarding the log4cxx_intptr_t type.
This type is only used in StringHelper::formatHex(),
which iteself is again only used to convert the thread
id returned by apr_os_thread_current().
The APR itself already provides a portable way of converting
an apr_os_thread_id to a string by passing a special format
specifier to apr_snprintf(). Thus, my solution (patch attached)
is to use this portable method and to completely remove the
not-so-portable log4cxx_intptr_t type.
Drawback(?): this specific format specifier for apr_os_thread_id
was introduced as new feature with APR 1.2, which would mean
that APR 1.2 will be mandatory (not a big issue in my opinion)
starting with this patch.
Any comments?

Thanks and best Regards,

  Andreas

- --
Andreas Fester
mailto:andreas@littletux.net
WWW: http://www.littletux.net
ICQ: 326674288
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDY1cjZ3bQVzeW+rsRAqFGAKCqeFiO2MaxSDjRxoJVGf1mSRfdtgCfRv8O
1dbI/zo7pIhzS2lJRMe6pzY=
=RLX4
-----END PGP SIGNATURE-----

Mime
View raw message