From general-return-1633-apmail-logging-general-archive=logging.apache.org@logging.apache.org Wed Aug 17 07:45:06 2011 Return-Path: X-Original-To: apmail-logging-general-archive@www.apache.org Delivered-To: apmail-logging-general-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A8D5713B for ; Wed, 17 Aug 2011 07:45:06 +0000 (UTC) Received: (qmail 60576 invoked by uid 500); 17 Aug 2011 07:45:03 -0000 Delivered-To: apmail-logging-general-archive@logging.apache.org Received: (qmail 60399 invoked by uid 500); 17 Aug 2011 07:44:54 -0000 Mailing-List: contact general-help@logging.apache.org; run by ezmlm Precedence: bulk list-help: list-unsubscribe: List-Post: Reply-To: "Logging General" List-Id: Delivered-To: mailing list general@logging.apache.org Received: (qmail 60378 invoked by uid 99); 17 Aug 2011 07:44:50 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2011 07:44:50 +0000 X-ASF-Spam-Status: No, hits=3.5 required=5.0 tests=FB_GET_MEDS,FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of scott.deboy@gmail.com designates 209.85.213.175 as permitted sender) Received: from [209.85.213.175] (HELO mail-yx0-f175.google.com) (209.85.213.175) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Aug 2011 07:44:43 +0000 Received: by yxi19 with SMTP id 19so684299yxi.34 for ; Wed, 17 Aug 2011 00:44:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=waWHeriulGhc/mj3qsoRBHc33s/p20+CyVlSBsdp8VU=; b=aLovDDPk8UfNUxRQIYgnXk0q4sz954BBmv8prH+knn4YguFmTboxOmDTUMJV4xXjwp DJsQ0x3eyG00al3ZG7qE4wFgLPyNsMiK+1fPoLEWCWRNSCHIWrVXSuKxdJgcE0nRazSy iRtqOhNN2do5ZQ6hovz3N4mOKyIcquwP5ib3w= MIME-Version: 1.0 Received: by 10.43.50.5 with SMTP id vc5mr496570icb.455.1313567062926; Wed, 17 Aug 2011 00:44:22 -0700 (PDT) Received: by 10.42.178.70 with HTTP; Wed, 17 Aug 2011 00:44:22 -0700 (PDT) In-Reply-To: <8739h033do.fsf@v35516.1blu.de> References: <20110817071343.E5DDF2388847@eris.apache.org> <8739h033do.fsf@v35516.1blu.de> Date: Wed, 17 Aug 2011 00:44:22 -0700 Message-ID: Subject: Re: svn commit: r1158546 - in /logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw: LogFilePatternLayoutBuilder.java LogUI.java vfs/VFSLogFilePatternReceiver.java From: Scott Deboy To: Logging General Content-Type: multipart/alternative; boundary=bcaec529a0332ca63904aaaeaa81 --bcaec529a0332ca63904aaaeaa81 Content-Type: text/plain; charset=ISO-8859-1 Thanks Stefan, I'll take care of it.. On Wed, Aug 17, 2011 at 12:26 AM, Stefan Bodewig wrote: > Hi Scott, > > I don't know why commit mails go to the general list, but this one > caught my eye: > > On 2011-08-17, wrote: > > > Node fileNameNode = > appenderChild.getAttributes().getNamedItem("name"); > > - if (fileNameNode != null && > fileNameNode.getNodeValue().equals("file")) { > > + If (fileNameNode != null && > fileNameNode.getNodeValue().toLowerCase().equals("file")) { > > this is a locale sensitive comparison which is likely to cause problems > in the famous Turkish/Azeri locale case ("I".toLowerCase() != "i" > there). > > You may want to use fileNameNode.getNodeValue().equalsIgnoreCase("file") > instead, which is safe. > > Stefan > --bcaec529a0332ca63904aaaeaa81 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Thanks Stefan, I'll take care of it..

On Wed, Aug 17, 2011 at 12:26 AM, Stefan Bodewig <bodewig@apache.org> wrote:=
Hi Scott,

I don't know why commit mails go to the general list, but this one
caught my eye:

On 2011-08-17, <sdeboy@apache.org> wrote:

> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0Node fileNameNode =3D appenderChild= .getAttributes().getNamedItem("name");
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (fileNameNode !=3D null &&= fileNameNode.getNodeValue().equals("file")) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0If (fileNameNode !=3D null &&= fileNameNode.getNodeValue().toLowerCase().equals("file")) {

this is a locale sensitive comparison which is likely to cause proble= ms
in the famous Turkish/Azeri locale case ("I".toLowerCase() !=3D &= quot;i"
there).

You may want to use fileNameNode.getNodeValue().equalsIgnoreCase("file= ")
instead, which is safe.

Stefan

--bcaec529a0332ca63904aaaeaa81--