logging-general mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: svn commit: r1158546 - in /logging/chainsaw/trunk/src/main/java/org/apache/log4j/chainsaw: LogFilePatternLayoutBuilder.java LogUI.java vfs/VFSLogFilePatternReceiver.java
Date Wed, 17 Aug 2011 07:26:27 GMT
Hi Scott,

I don't know why commit mails go to the general list, but this one
caught my eye:

On 2011-08-17, <sdeboy@apache.org> wrote:

>                  Node fileNameNode = appenderChild.getAttributes().getNamedItem("name");
> -                if (fileNameNode != null && fileNameNode.getNodeValue().equals("file"))
{
> +                If (fileNameNode != null && fileNameNode.getNodeValue().toLowerCase().equals("file"))
{

this is a locale sensitive comparison which is likely to cause problems
in the famous Turkish/Azeri locale case ("I".toLowerCase() != "i"
there).

You may want to use fileNameNode.getNodeValue().equalsIgnoreCase("file")
instead, which is safe.

Stefan

Mime
View raw message