logging-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mattsic...@apache.org
Subject svn commit: r1587419 - /logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/util/Profiler.java
Date Tue, 15 Apr 2014 05:15:47 GMT
Author: mattsicker
Date: Tue Apr 15 05:15:47 2014
New Revision: 1587419

URL: http://svn.apache.org/r1587419
Log:
Add logger and more terse reflection.

Modified:
    logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/util/Profiler.java

Modified: logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/util/Profiler.java
URL: http://svn.apache.org/viewvc/logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/util/Profiler.java?rev=1587419&r1=1587418&r2=1587419&view=diff
==============================================================================
--- logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/util/Profiler.java
(original)
+++ logging/log4j/log4j2/trunk/log4j-core/src/test/java/org/apache/logging/log4j/core/util/Profiler.java
Tue Apr 15 05:15:47 2014
@@ -16,28 +16,31 @@
  */
 package org.apache.logging.log4j.core.util;
 
-import java.lang.reflect.Field;
+import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.core.helpers.Loader;
+import org.apache.logging.log4j.status.StatusLogger;
 
 /**
  * YourKit Java Profiler helper class.
  */
 public final class Profiler {
+    private static final Logger LOGGER = StatusLogger.getLogger();
+
     private static Object profiler;
     private static Class<?> profilingModes;
     private static Class<?> controllerClazz;
 
     static {
         try {
-            controllerClazz = Class.forName("com.yourkit.api.Controller");
-            profilingModes = Class.forName("com.yourkit.api.ProfilingModes");
+            controllerClazz = Loader.loadClass("com.yourkit.api.Controller");
+            profilingModes = Loader.loadClass("com.yourkit.api.ProfilingModes");
             try {
-                profiler = controllerClazz.newInstance();
+                profiler = controllerClazz.getConstructor().newInstance();
             } catch (final Exception e) {
-                e.printStackTrace();
-                System.out.println("Profiler was active, but failed due: " + e.getMessage());
+                LOGGER.error("Profiler was active, but failed.", e);
             }
         }
-        catch (final Exception e) {
+        catch (final Exception ignored) {
             // Ignore
         }
 
@@ -50,20 +53,24 @@ public final class Profiler {
         return profiler != null;
     }
 
+    private static long cpuSampling() throws NoSuchFieldException, IllegalAccessException
{
+        return profilingModes.getDeclaredField("CPU_SAMPLING").getLong(profilingModes);
+    }
+
+    private static long snapshotWithoutHeap() throws NoSuchFieldException, IllegalAccessException
{
+        return profilingModes.getDeclaredField("SNAPSHOT_WITHOUT_HEAP").getLong(profilingModes);
+    }
+
     public static void start() {
 
         if (profiler != null) {
             try {
-                final Field f = profilingModes.getDeclaredField("CPU_SAMPLING");
-                final Object[] args = new Object[2];
-                args[0] = f.getLong(profilingModes);
-                args[1] = "";
-                final Class<?>[] parms = new Class<?>[] {long.class, String.class};
-                controllerClazz.getMethod("startCPUProfiling", parms).invoke(profiler, args);
+                controllerClazz
+                        .getMethod("startCPUProfiling", long.class, String.class)
+                        .invoke(profiler, cpuSampling(), "");
             }
             catch (final Exception e) {
-                e.printStackTrace();
-                System.out.println("Profiler was active, but failed due: " + e.getMessage());
+                LOGGER.error("Profiler was active, but failed.", e);
             }
         }
     }
@@ -71,16 +78,15 @@ public final class Profiler {
     public static void stop() {
         if (profiler != null) {
             try {
-                final Field f = profilingModes.getDeclaredField("SNAPSHOT_WITHOUT_HEAP");
-                final Object[] args = new Object[1];
-                args[0] = f.getLong(profilingModes);
-                final Class<?>[] parms = new Class<?>[] {long.class};
-                profiler.getClass().getMethod("captureSnapshot", parms).invoke(profiler,
args);
-                profiler.getClass().getMethod("stopCPUProfiling").invoke(profiler);
+                controllerClazz
+                        .getMethod("captureSnapshot", long.class)
+                        .invoke(profiler, snapshotWithoutHeap());
+                controllerClazz
+                        .getMethod("stopCPUProfiling")
+                        .invoke(profiler);
             }
             catch (final Exception e) {
-                e.printStackTrace();
-                System.out.println("Profiler was active, but failed due: " + e.getMessage());
+                LOGGER.error("Profiler was active, but failed.", e);
             }
         }
     }



Mime
View raw message